Use Accept-Language header for locale in ConfigurableServiceResource #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most RESTResources already use the LocaleService to get the locale based on the Accept-Language header and use the system locale only as fallback. Because the ConfigurableServiceResource does not do this, it results in mixed up languages whenever your browser locale is not the same as the configured system locale. See: * https://community.openhab.org/t/language-support-question-regional-settings-language-vs-browser-language/128010 * openhab/openhab-webui#1083 Signed-off-by: Wouter Born <[email protected]>
|
Great to have a solution for this! 👍 |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
…penhab#2602) Most RESTResources already use the LocaleService to get the locale based on the Accept-Language header and use the system locale only as fallback. Because the ConfigurableServiceResource does not do this, it results in mixed up languages whenever your browser locale is not the same as the configured system locale. See: * https://community.openhab.org/t/language-support-question-regional-settings-language-vs-browser-language/128010 * openhab/openhab-webui#1083 Signed-off-by: Wouter Born <[email protected]> GitOrigin-RevId: 69043be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most RESTResources already use the LocaleService to get the locale based on the Accept-Language header and use the system locale only as fallback.
Because the ConfigurableServiceResource does not do this, it results in mixed up languages whenever your browser locale is not the same as the configured system locale.
See: