[automation] Add basic time-related classes for usage in script and rules #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Weitkamp <[email protected]>
cweitkamp
added
enhancement
cweitkamp
changed the title
|
The replacement that I am actually using in my rules is but it all isn't as nice as the |
kaikreuzer
changed the title
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
…ab#2587) Signed-off-by: Christoph Weitkamp <[email protected]> GitOrigin-RevId: 793ced6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use DateTime functions a lot easier for users without defining additional imports. We have public methods in different types which makes use of these classes e.g.
openhab-core/bundles/org.openhab.core/src/main/java/org/openhab/core/library/types/DateTimeType.java
Line 170 in a9504bf
openhab-core/bundles/org.openhab.core.model.script/src/org/openhab/core/model/script/actions/Timer.java
Line 76 in a9504bf
org.joda.timeAPI has a methodDateTime.now().withTimeAtStartOfDay()which was used by many users. The replacement isZonedDateTime.now().truncatedTo(ChronoUnit.DAYS).Durationclass allows easy calculation of differences between two timestamps (Duration.between(Temporal startInclusive, Temporal endExclusive)-ZonedDateTimeimplemetsTemporalinterface).Signed-off-by: Christoph Weitkamp [email protected]