Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[automation] Allow UoM in 'ItemStateCondition' #2435

Merged
merged 2 commits into from
Jul 31, 2021
Merged

[automation] Allow UoM in 'ItemStateCondition' #2435

merged 2 commits into from
Jul 31, 2021

Conversation

cweitkamp
Copy link
Contributor

  • Allow UoM in ItemStateCondition

The user will see a warning if Item has a QuantityState and the comparison value is defined as decimal (similar to offset Profile).

[main] WARN org.openhab.core.automation.internal.module.handler.ItemStateConditionHandler - Received a QuantityType state '23 °C' with unit, but the condition is defined as a plain number without unit (5), please consider adding a unit to the condition.

Fixes #2426

Signed-off-by: Christoph Weitkamp [email protected]

@cweitkamp
Allow UoM in ItemStateConditions
96fa15a 
Signed-off-by: Christoph Weitkamp <[email protected]>
@cweitkamp cweitkamp added bug An unexpected problem or unintended behavior of the Core automation labels Jul 22, 2021
@cweitkamp cweitkamp requested a review from a team as a code owner July 22, 2021 11:40
@cweitkamp
Revert renamed file
daa73c8 
Signed-off-by: Christoph Weitkamp <[email protected]>
kaikreuzer
kaikreuzer approved these changes Jul 31, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer added this to the 3.2 milestone Jul 31, 2021
@kaikreuzer kaikreuzer merged commit 66847eb into openhab:main Jul 31, 2021
@cweitkamp cweitkamp deleted the bugfix-2426-uom-in-itemstatecondition branch July 31, 2021 17:37
ghys pushed a commit to ghys/openhab-core that referenced this pull request Sep 9, 2021
@cweitkamp @ghys
[automation] Allow UoM in 'ItemStateCondition' (openhab#2435)
7c018e6 
* Allow UoM in ItemStateConditions

Signed-off-by: Christoph Weitkamp <[email protected]>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@cweitkamp @splatch
[automation] Allow UoM in 'ItemStateCondition' (openhab#2435)
309d8fb 
* Allow UoM in ItemStateConditions

Signed-off-by: Christoph Weitkamp <[email protected]>
GitOrigin-RevId: 66847eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
automation bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

[automation] UoM in ItemStateCondition
2 participants
@cweitkamp @kaikreuzer