Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[item] Create a deep copy of the first found fragment before merging other fragments into it #2412

Merged
merged 1 commit into from
Jun 24, 2021
Merged

[item] Create a deep copy of the first found fragment before merging other fragments into it #2412

merged 1 commit into from
Jun 24, 2021

Conversation

cweitkamp
Copy link
Contributor

  • Create a deep copy of the first found fragment before merging other fragments into it

Fixes #2409

Signed-off-by: Christoph Weitkamp [email protected]

@cweitkamp cweitkamp added the bug An unexpected problem or unintended behavior of the Core label Jun 24, 2021
@cweitkamp cweitkamp requested a review from a team as a code owner June 24, 2021 10:29
lolodomo
lolodomo approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for the fix.

I have not checked in detail your changes in tests.

kaikreuzer
kaikreuzer approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for looking into this!

@kaikreuzer kaikreuzer merged commit 57c716b into openhab:main Jun 24, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Jun 24, 2021
@kaikreuzer
Copy link
Member

I've directly launched a new core build: https://ci.openhab.org/job/openHAB-Core/796/

@cweitkamp cweitkamp deleted the bugfix-2409-deep-copy-statedescriptionfragments branch June 24, 2021 16:46
@lolodomo
Copy link
Contributor

Fantastic, I just tested your change in my Eclipse environment and it clearly solves the issue. List of state options is now correct in Basic UI, in Main UI and in item REST API.
Thank you a lot for fixing that quickly.

I will now be able to work on the UI changes to consider the new event.

ghys pushed a commit to ghys/openhab-core that referenced this pull request Sep 9, 2021
@cweitkamp @ghys
Create a deep copy of the first found fragment before merging other f…
d0d4a31 
…ragments into it (openhab#2412)

Signed-off-by: Christoph Weitkamp <[email protected]>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@cweitkamp @splatch
Create a deep copy of the first found fragment before merging other f…
c1102bf 
…ragments into it (openhab#2412)

Signed-off-by: Christoph Weitkamp <[email protected]>
GitOrigin-RevId: 57c716b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

Update of dynamic state options in UIs is broken
3 participants
@cweitkamp @kaikreuzer @lolodomo