Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[automation] Expose TriggerHandlerCallback scheduler #2388

Merged
merged 2 commits into from
May 31, 2021
Merged

[automation] Expose TriggerHandlerCallback scheduler #2388

merged 2 commits into from
May 31, 2021

Conversation

fwolter
Copy link
Member

@fwolter fwolter commented May 29, 2021 •
edited by kaikreuzer
Loading

Originated from openhab/openhab-addons#10205 (comment)

Signed-off-by: Fabian Wolter [email protected]

@fwolter fwolter requested a review from a team as a code owner May 29, 2021 14:02
@kaikreuzer
Copy link
Member

Build fails with

[ERROR] /home/jenkins/jenkins-agent1/workspace/PR-openHAB-Core/bundles/org.openhab.core.automation.module.script.rulesupport/src/main/java/org/openhab/core/automation/module/script/rulesupport/internal/delegates/SimpleTriggerHandlerCallbackDelegate.java:[28,14] The type org.openhab.core.automation.module.script.rulesupport.internal.delegates.SimpleTriggerHandlerCallbackDelegate must implement the inherited abstract method org.openhab.core.automation.handler.TriggerHandlerCallback.getScheduler()

@fwolter
Remove initialize()
24a42d4 
Signed-off-by: Fabian Wolter <[email protected]>
@kaikreuzer kaikreuzer changed the title [automation] Expose TriggerHandlerCallback scheduler; add initialize() method [automation] Expose TriggerHandlerCallback scheduler May 31, 2021
@kaikreuzer kaikreuzer added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels May 31, 2021
kaikreuzer
kaikreuzer approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit e007307 into openhab:main May 31, 2021
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label May 31, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone May 31, 2021
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@fwolter @splatch
[automation] Expose TriggerHandlerCallback scheduler (openhab#2388)
f77882e 
* [automation] Expose TriggerHandlerCallback scheduler

Signed-off-by: Fabian Wolter <[email protected]>
GitOrigin-RevId: e007307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
automation enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fwolter @kaikreuzer @cweitkamp