Fix MQTT QoS levels setting #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
Will implicitly also fix issue in mqtt.homie binding: |
|
I think the changes are good! Can you also sign off your commit or provide the |
|
I think we can treat that as a small patch exception and skip the DCO. |
kaikreuzer
changed the title
kaikreuzer
approved these changes
Feb 27, 2021
kaikreuzer
added
the
bug
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/irobot-9xx-on-openhab/17774/239 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/irobot-9xx-on-openhab/17774/258 |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
…ab#2208) Signed-off-by: Stefan Donath <[email protected]> GitOrigin-RevId: 361e985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #2145 "io transport mqtt sets wrong QoS levels to hiveMQ"
#2145
Fix is simply exchanging the enum values returned for the case 0 and case 1 branches, as they have been mixed up as compared to the mqtt specification: