Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add current owner to PortInUseException #2126

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Add current owner to PortInUseException #2126

merged 2 commits into from
Jan 21, 2021

Conversation

fwolter
Copy link
Member

@fwolter fwolter commented Jan 17, 2021

I don't know when the javacomm bundle is needed, so I applied the changes there, too.

@fwolter fwolter requested a review from a team as a code owner January 17, 2021 18:21
@wborn
Copy link
Member

wborn commented Jan 18, 2021

It would also be helpful to preserve the root cause exception as cause in thrown exceptions. The serial transport also does this when throwing an UnsupportedCommOperationException .

Base automatically changed from master to main January 18, 2021 20:04
Preserve cause
f19bf78 
Signed-off-by: Fabian Wolter <[email protected]>
@fwolter
Copy link
Member Author

fwolter commented Jan 20, 2021

Like so?

wborn
wborn approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wborn wborn merged commit 0a2450c into openhab:main Jan 21, 2021
@wborn wborn added this to the 3.1 milestone Jan 21, 2021
@Hilbrand Hilbrand mentioned this pull request Jan 21, 2021
Merged
@cweitkamp cweitkamp added the enhancement An enhancement or new feature of the Core label Feb 6, 2021
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@fwolter @splatch
Add message and preserve cause when throwing PortInUseException (open…
7b27a8e 
…hab#2126)

Signed-off-by: Fabian Wolter <[email protected]>
GitOrigin-RevId: 0a2450c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fwolter @wborn @cweitkamp