Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also return command line execution result in case of error return code #2104

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Also return command line execution result in case of error return code #2104

merged 1 commit into from
Jan 12, 2021

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer kaikreuzer commented Jan 11, 2021 •
edited by cweitkamp
Loading

Fixes #2033
Fixes #2078

Signed-off-by: Kai Kreuzer [email protected]

@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of the Core label Jan 11, 2021
@kaikreuzer kaikreuzer requested a review from a team as a code owner January 11, 2021 20:34
@kaikreuzer kaikreuzer mentioned this pull request Jan 11, 2021
Closed
Confectrician
Confectrician approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@Confectrician Confectrician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lolodomo
Copy link
Contributor

@kaikreuzer : can you please check that it will not break any existing OH3 binding?

@kaikreuzer
Copy link
Member Author

@lolodomo I found 4 uses of the method, all of them should work nicely with that change.

@kaikreuzer kaikreuzer added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Jan 11, 2021
@lolodomo
Copy link
Contributor

Thank you.

@cweitkamp cweitkamp added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Jan 12, 2021
@wborn wborn added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Jan 12, 2021
wborn
wborn approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit a0d5800 into openhab:master Jan 12, 2021
@cweitkamp cweitkamp added this to the 3.1 milestone Jan 12, 2021
@cweitkamp cweitkamp added the patch A PR that has been cherry-picked to a patch release branch label Jan 16, 2021
cweitkamp pushed a commit that referenced this pull request Jan 16, 2021
@kaikreuzer @cweitkamp
Also return command line execution result in case of error return code (
07c3302 
#2104)

Signed-off-by: Kai Kreuzer <[email protected]>
@kaikreuzer kaikreuzer mentioned this pull request Jan 16, 2021
Merged
soenkekueper pushed a commit to soenkekueper/openhab-core that referenced this pull request Jan 17, 2021
@kaikreuzer @soenkekueper
Also return command line execution result in case of error return code (
92fe104 
openhab#2104)

Signed-off-by: Kai Kreuzer <[email protected]>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@kaikreuzer @splatch
Also return command line execution result in case of error return code (
8054d53 
openhab#2104)

Signed-off-by: Kai Kreuzer <[email protected]>
GitOrigin-RevId: a0d5800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Confectrician Confectrician Confectrician approved these changes

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
3.1
5 participants
@kaikreuzer @lolodomo @Confectrician @wborn @cweitkamp