Use the same regex as the install and uninstall method #1543
Conversation
Signed-off-by: Simon Lamon <[email protected]>
cweitkamp
added
bug
| @@ -138,7 +138,7 @@ public Response getTypes(@HeaderParam("Accept-Language") @ApiParam(value = "lang | |||
| } | |||
|
|
|||
| @GET | |||
| @Path("/{extensionId: [a-zA-Z_0-9-]+}") | |||
| @Path("/{extensionId: [a-zA-Z_0-9-:]+}") | |||
There was a problem hiding this comment.
I am a fan of streamlining it but not sure if we should add the colon here or rather remove it from install/uninstall methods.
@kaikreuzer You introduced the colon in eclipse-archived/smarthome#3076 because the marketplace adds marcetplace: prefix. As the Marketplace itself is EOL. What is your opinion on this?
There was a problem hiding this comment.
As the Marketplace itself is EOL
I would not say so. What we will drop is the Eclipse IoT Marketplace extension service, but not the general marketplace extension mechanism (see openhab/openhab-addons#6673).
We will therefore need a way to differentiate between "distro" add-ons and stuff that comes from other (external) sources. And using colons for such namespaces imho still makes sense, so I would keep it in place.
cweitkamp
removed
the
bug
Signed-off-by: Simon Lamon <[email protected]> GitOrigin-RevId: c788f2f
The getById method is missing the ":". See the install and uninstall method.