Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run resolver on integration tests to fix the build #1277

Merged
merged 2 commits into from
Dec 15, 2019

Conversation

cweitkamp
Copy link
Contributor

  • Run resolver on integration tests to fix the build

@pfink Do you think it is possible to add the resolver - Maven flag -DwithResolver for itest/ folder - to the unleash step of the build pipeline?

Signed-off-by: Christoph Weitkamp [email protected]

@cweitkamp cweitkamp added the test label Dec 15, 2019
@pfink
Copy link
Contributor

pfink commented Dec 15, 2019

@pfink Do you think it is possible to add the resolver - Maven flag -DwithResolver for itest/ folder - to the unleash step of the build pipeline?

Sure, this would be the right place.

Signed-off-by: Christoph Weitkamp <[email protected]>
@cweitkamp
Copy link
Contributor Author

cweitkamp commented Dec 15, 2019

That was a quick response. Thank you.

Will those flags be applied in all repositories? I think we need them in openHAB 2 Add-ons and more.

I am not sure if we use -DskipTests, will the resolver be applied on the itests? Do you know that?

@pfink
Copy link
Contributor

pfink commented Dec 15, 2019

Some time ago, I did a PR to ensure itests are always part of the reactor during release, even if skipTests is enabled, because it lead to issues that they were missing: #673

I don't know more about it.

Flags will be applied to all repos.

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 170e486 into openhab:master Dec 15, 2019
@cweitkamp cweitkamp deleted the feature-fix-itests branch December 16, 2019 05:52
@wborn wborn added this to the 3.0 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants