Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default SslContextFactory excludes for weak ciphers and protocols #1241

Merged
merged 1 commit into from
Nov 25, 2019
+0 −6
Merged

Use default SslContextFactory excludes for weak ciphers and protocols #1241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ...io.net/src/main/java/org/eclipse/smarthome/io/net/http/internal/WebClientFactoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,10 +388,6 @@ private SslContextFactory createSslContextFactoryFromExtensibleTrustManager() {
} catch (NoSuchAlgorithmException | KeyManagementException ex) {
throw new HttpClientInitializationException("Cannot create an TLS context!", ex);
}
// Exclude weak / insecure ciphers
sslContextFactory.addExcludeCipherSuites("^.*_(MD5|SHA|SHA1)$");
// Exclude ciphers that don't support forward secrecy
sslContextFactory.addExcludeCipherSuites("^TLS_RSA_.*$");
return sslContextFactory;
}

Expand All @@ -416,8 +412,6 @@ private SslContextFactory createSslContextFactoryFromTrustManagerProvider(@Nulla
}
}

String excludeCipherSuites[] = { "^.*_(MD5)$" };
sslContextFactory.setExcludeCipherSuites(excludeCipherSuites);
return sslContextFactory;
}

Expand Down