-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rest] Allow colons in SSE topics filter #1052
Conversation
Thanks. Can you please sign-off your work? It would be nice to have some unit tests for the new pattern to cover at least all available core events. May I ask you to add them? |
I signed off the work and added some tests for the single entity filter. |
Unfortunately the test failed https://travis-ci.org/openhab/openhab-core/jobs/591061769#L2130 - It looks like the dash ("-") is not allowed too:
|
That's strange, why did it pass when I ran it locally in Eclipse? |
Okay, apparently I didn't rebuild the bundle before running tests. Should I add another commit? or modify the previous? |
Signed-off-by: Feras Almanna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. And thank you very much for your first contribution over here.
Removed structure from binding page as it's duplicated on the guidelines page. Updated and improved the description on the guidelines page with the information that was on the bindings page (that information was improved recently). Signed-off-by: Hilbrand Bouwkamp <[email protected]>
…#1052) Fixes openhab#1043 Signed-off-by: Feras Almanna <[email protected]> GitOrigin-RevId: b48f1c1
fixes #1043