[rest] Added new Audio API #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Garnier <[email protected]>
cweitkamp
reviewed
Sep 13, 2019
There was a problem hiding this comment.
Thank you very much. The code looks pretty good. Two minor comments.
Should we add a feature for it too? Like we did for the voice REST API?
openhab-core/features/karaf/openhab-core/src/main/feature/feature.xml
Lines 173 to 176 in fa416be
| if (source != null) { | ||
| return Response.ok(AudioMapper.map(source, locale)).build(); | ||
| } else { | ||
| return JSONResponse.createErrorResponse(Status.NOT_FOUND, "source not found"); |
There was a problem hiding this comment.
Suggested change
| return JSONResponse.createErrorResponse(Status.NOT_FOUND, "source not found"); | |
| return JSONResponse.createErrorResponse(Status.NOT_FOUND, "Source not found"); |
| if (sink != null) { | ||
| return Response.ok(AudioMapper.map(sink, locale)).build(); | ||
| } else { | ||
| return JSONResponse.createErrorResponse(Status.NOT_FOUND, "sink not found"); |
There was a problem hiding this comment.
Suggested change
| return JSONResponse.createErrorResponse(Status.NOT_FOUND, "sink not found"); | |
| return JSONResponse.createErrorResponse(Status.NOT_FOUND, "Sink not found"); |
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]>
|
I added the feature stuff. |
cweitkamp
approved these changes
Sep 14, 2019
cweitkamp
added
rebuild
Rosi2143
pushed a commit
to Rosi2143/openhab-core
that referenced
this pull request
Dec 26, 2020
* Update eclipse.md Fix a few typos and improve readability. Signed-off-by: Matthew Skinner (Skinah) <[email protected]> * Added newline Signed-off-by: Jerome Luckenbach <[email protected]>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
* New Audio REST API Signed-off-by: Laurent Garnier <[email protected]> GitOrigin-RevId: cf4b752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laurent Garnier [email protected]