[rest] Added Voice / TTS API #1017
Conversation
Fix #927 Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
changed the title
lolodomo
changed the title
|
In addition to this enhancement, we need another REST API for audio to get the list of audio sinks. I will cover that in a separate PR. |
Signed-off-by: Laurent Garnier <[email protected]>
| @@ -67,6 +71,7 @@ | |||
| UriInfo uriInfo; | |||
|
|
|||
| private VoiceManager voiceManager; | |||
| private AudioManager audioManager; | |||
There was a problem hiding this comment.
You should imho do without that dependency - the VoiceManager offers methods to call without sinkIds and it handles the calls internally. The REST API should behave the same way as the Java API.
There was a problem hiding this comment.
Ok, this was necessary just to make a pre-control and avoid returning status 200 when say will fail because the provided audio sink is wrong.
But I can suppress this test and so this dependency to AudoManager.
| } | ||
|
|
||
| @POST | ||
| @Path("/say/{sinkid: [a-zA-Z_:0-9]*}") |
There was a problem hiding this comment.
The sinkId is not a member of an entity "say", so it should imho rather be a QueryParam instead of a PathParam here.
There was a problem hiding this comment.
Makes sense.
I think I do it like that because the interpret API just above was using this pattern.
There was a problem hiding this comment.
Right, but for the interpreters call, it is selecting an entity by id from the list of interpreters, so it is a different situation.
There was a problem hiding this comment.
I don't understand the difference.
Here I want to select a voice amongst a list of voices, and a sink amongst a list of audio sinks.
There was a problem hiding this comment.
Your uri is say/sinkid and not sinks/sinkid or voices/voiceid. Hence "sinkid" is not an entity of the "say" entities. See the difference?
There was a problem hiding this comment.
I see what you mean now.
| } | ||
|
|
||
| @POST | ||
| @Path("/say/{sinkid: [a-zA-Z_:0-9]*}/{voiceid: [a-zA-Z_:0-9]*}") |
There was a problem hiding this comment.
Same here: Make sinkid and voiceid to QueryParams (this will actually allow you to combine the three methods into one as two params can both be optional).
There was a problem hiding this comment.
Is it possible to have QueryParam in a POST command ?
There was a problem hiding this comment.
I have a doubt. I will check if we have such case in all our REST APIs (POST).
There was a problem hiding this comment.
Doing a WEB search, it looks like this is possible.
Signed-off-by: Laurent Garnier <[email protected]>
|
Changes done. My tests are ok. |
cweitkamp
changed the title
…". If you do you will see this `warning: 2019-07-11 20:57:02.024 [WARN ] [el.core.internal.ModelRepositoryImpl] - Configuration model 'groundfloor.sitemap' has errors, therefore ignoring it: [31,91]: mismatched input '"20"' expecting RULE_INT` (openhab#1017) Line 31 from groundfloor.sitemap: ``` Colorpicker item=cinema_led_strip_color label="Cinema LED Strip Color[]" sendFrequency="20" ``` Signed-off-by: Soren Thorsen <[email protected]>
* REST Voice API: new API for TTS Fix openhab#927 Signed-off-by: Laurent Garnier <[email protected]> GitOrigin-RevId: a1f3880
Fix #927
Signed-off-by: Laurent Garnier [email protected]