Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Selection widget as default widget for Number or String items with options #1009

Merged
merged 2 commits into from
Aug 30, 2019
Merged

[ui] Selection widget as default widget for Number or String items with options #1009

merged 2 commits into from
Aug 30, 2019

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Aug 29, 2019

Fixes #984

Signed-off-by: Laurent Garnier [email protected]

Before the change (display from a group so with the default rendering):
image

And now with this change in Basic UI:
image

And in Classic UI:
image

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks.

@lolodomo
Copy link
Contributor Author

Maybe I should check that the item is not read only. If read only, use the text widget.

@kaikreuzer
Copy link
Member

Yes, if that information is available, it would be nice to be used. I'll wait with the merge, so you can amend that to the PR, if you like.

@lolodomo
Copy link
Contributor Author

@kaikreuzer : it is done.

@kaikreuzer kaikreuzer merged commit e7d1826 into openhab:master Aug 30, 2019
@cweitkamp cweitkamp added this to the 2.5 milestone Aug 30, 2019
@lolodomo lolodomo deleted the default_selection branch August 30, 2019 12:33
@lolodomo
Copy link
Contributor Author

I installed the snapshot 1674, thinking this new feature will be included. Unfortunately, it isn't. Checking the core bundles versions, I discovered that they are from August 28 only (not 30). Is it due to failing builds of openHAB core since few days ?

@kaikreuzer
Copy link
Member

Yes.

@lolodomo
Copy link
Contributor Author

lolodomo commented Sep 2, 2019

The problem seems to be a missing dependency in the DBus transport bundle. @maggu2810 : can you have a look please ? It is a dependency to something from you apparently.

@kaikreuzer
Copy link
Member

@lolodomo The problem came with #1011, see my comment #1011 (comment).
Still trying to understand why the build isn't checking for the correct repositories.

@cweitkamp cweitkamp added enhancement An enhancement or new feature of the Core UI User Interface labels Dec 3, 2019
@cweitkamp cweitkamp changed the title Selection widget as default widget for Number or String items with options [ui] Selection widget as default widget for Number or String items with options Dec 3, 2019
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/kodi-binding-problem-with-navigation-in-the-ui/87044/10

Rosi2143 pushed a commit to Rosi2143/openhab-core that referenced this pull request Dec 26, 2020
Clarify usage of * asterisk in persistence strategy configuration.
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
…tions (openhab#1009)

* Selection widget as default widget for Number or String items with options

Fixes openhab#984

Signed-off-by: Laurent Garnier <[email protected]>
GitOrigin-RevId: e7d1826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection widget by default for items with state options
4 participants