Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[automation] Rules are added twice after modifying JSR223 (Python) files #2246

Closed
cweitkamp opened this issue Mar 20, 2021 · 2 comments · Fixed by #2254
Closed

[automation] Rules are added twice after modifying JSR223 (Python) files #2246

cweitkamp opened this issue Mar 20, 2021 · 2 comments · Fixed by #2254
Labels
automation bug An unexpected problem or unintended behavior of the Core

Comments

@cweitkamp
Copy link
Contributor

After modification of textual Rule files (Python) the Rules are created twice:

openhab> automation listRules | grep Energy
20     08db0ffa-a6f7-44fe-8404-42a0226f8124 Energy - Trigger for sensorTerraceEnergy changed IDLE           
182    6d24f9ae-c787-4452-b623-b82727d6063d Energy - Trigger for sensorTerracePower changed IDLE           
258    97d39ee5-b517-4377-bb37-928efb1a193c Energy - Trigger for sensorTerracePower changed IDLE           
278    abfa6e83-cf1b-4ec3-8242-7d5aefc86b13 Energy - Trigger for sensorTerraceEnergy changed IDLE

grafik

// CC @jpg0 Do you think this could be related to #2222? I observed this issue since a few days. I am not aware ti was happening before.
@cweitkamp cweitkamp added bug An unexpected problem or unintended behavior of the Core automation labels Mar 20, 2021
@jpg0
Copy link
Contributor

jpg0 commented Mar 24, 2021

hi @cweitkamp, I just updated my system to the latest snapshot (including #2222) to take a look at this. I am seeing the same behaviour; I'll try to figure out what is causing it...

jpg0 added a commit to jpg0/openhab-core that referenced this issue Mar 24, 2021
@jpg0
Correctly unload script before reload. Fixes openhab#2246
1b7f1b9 
Signed-off-by: Jonathan Gilbert <[email protected]>
@jpg0
Copy link
Contributor

jpg0 commented Mar 24, 2021

Found it, you're right, it was #2222. Sorry about that! PR to fix is #2254.

@cweitkamp cweitkamp linked a pull request Mar 25, 2021 that will close this issue
Correctly unload script before reload. Fixes #2246 #2254
Merged
jpg0 added a commit to jpg0/openhab-core that referenced this issue Mar 25, 2021
@jpg0
Correctly unload script before reload. Fixes openhab#2246
11ebeca 
Signed-off-by: Jonathan Gilbert <[email protected]>
jpg0 added a commit to jpg0/openhab-core that referenced this issue Mar 25, 2021
@jpg0
Correctly unload script before reload. Fixes openhab#2246
b5ed34b 
Signed-off-by: Jonathan Gilbert <[email protected]>
jpg0 added a commit to jpg0/openhab-core that referenced this issue Mar 25, 2021
@jpg0
Correctly unload script before reload. Fixes openhab#2246
8f111e7 
Signed-off-by: Jonathan Gilbert <[email protected]>
jpg0 added a commit to jpg0/openhab-core that referenced this issue Mar 25, 2021
@jpg0
Correctly unload script before reload. Fixes openhab#2246
d1ff6ae 
Signed-off-by: Jonathan Gilbert <[email protected]>
cweitkamp pushed a commit that referenced this issue Mar 26, 2021
@jpg0
[automation] Correctly unload script before reload. (#2254)
6961db7 
- Correctly unload script before reload.

Fixes #2246

Signed-off-by: Jonathan Gilbert <[email protected]>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this issue Jul 11, 2023
@jpg0 @splatch
[automation] Correctly unload script before reload. (openhab#2254)
ad82576 
- Correctly unload script before reload.

Fixes openhab#2246

Signed-off-by: Jonathan Gilbert <[email protected]>
GitOrigin-RevId: 6961db7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly unload script before reload. Fixes #2246 jpg0/openhab-core
2 participants
@jpg0 @cweitkamp