review feedback

Signed-off-by: Mark Herwege <[email protected]>
openhab · Jun 12, 2023 · cc05b9c · cc05b9c
1 parent 0c0f57d
commit cc05b9c
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/....openhab.core.ui/src/main/java/org/openhab/core/ui/internal/items/ItemUIRegistryImpl.java b/....openhab.core.ui/src/main/java/org/openhab/core/ui/internal/items/ItemUIRegistryImpl.java
@@ -371,7 +371,7 @@ private Switch createPlayerButtons() {
                 }
             }
         } catch (ItemNotFoundException e) {
-            logger.error("Cannot retrieve item '{}' for widget {}", itemName, w.eClass().getInstanceTypeName());
+            logger.warn("Cannot retrieve item '{}' for widget {}", itemName, w.eClass().getInstanceTypeName());
         }
 
         boolean considerTransform = false;
@@ -457,7 +457,7 @@ private Switch createPlayerButtons() {
                 label = label.trim();
                 int index = label.indexOf("[");
                 if (index >= 0) {
-                    label = label.substring(0, label.indexOf("[") + 1) + formatPattern + "]";
+                    label = label.substring(0, index + 1) + formatPattern + "]";
                 }
             }
         }
@@ -519,7 +519,7 @@ private QuantityType<?> convertStateToWidgetUnit(QuantityType<?> quantityState,
             }
 
         } catch (ItemNotFoundException e) {
-            logger.error("Cannot retrieve item '{}' for widget {}", itemName, w.eClass().getInstanceTypeName());
+            logger.warn("Cannot retrieve item '{}' for widget {}", itemName, w.eClass().getInstanceTypeName());
         }
 
         return pattern;
@@ -662,7 +662,7 @@ private String transform(String label, boolean matchTransform, @Nullable String
                 Item item = getItem(itemName);
                 return convertState(w, item, item.getState());
             } catch (ItemNotFoundException e) {
-                logger.error("Cannot retrieve item '{}' for widget {}", itemName, w.eClass().getInstanceTypeName());
+                logger.warn("Cannot retrieve item '{}' for widget {}", itemName, w.eClass().getInstanceTypeName());
             }
         }
         return UnDefType.UNDEF;
@@ -1262,7 +1262,7 @@ public boolean getVisiblity(Widget w) {
             try {
                 item = itemRegistry.getItem(itemName);
             } catch (ItemNotFoundException e) {
-                logger.error("Cannot retrieve visibility item {} for widget {}", rule.getItem(),
+                logger.warn("Cannot retrieve visibility item {} for widget {}", rule.getItem(),
                         w.eClass().getInstanceTypeName());
 
                 // Default to visible!
@@ -1393,7 +1393,7 @@ public void removeRegistryHook(RegistryHook<Item> hook) {
                 return numberItem.getUnitSymbol();
             }
         } catch (ItemNotFoundException e) {
-            logger.debug("Failed to retrieve item during widget rendering: {}", e.getMessage());
+            logger.warn("Failed to retrieve item during widget rendering, item does not exist: {}", e.getMessage());
         }
 
         return "";