Fix brightness parsing #3490
Merged
Fix brightness parsing #3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While debugging issues with color items I discovered that two SSE events are sent when a slider with a color item is updated. Item: ```` label: Debug Color 1 type: Color category: oh:mdi:palette groupNames: [] groupType: None function: null tags: [] ```` Sitemap: ```` Slider item=D_Color iconcolor=["itemValue"] ```` The first event contains a state in the hsb format (`10,10,10`), the second events contains the brightness only (`10`). Parsing an integer as brightness failed and the slider was set to `0`. IMO an integer in the range `0..100` can be considered as brightness. Signed-off-by: mueller-ma <[email protected]>
mueller-ma
added a commit
to mueller-ma/openhab.android
that referenced
this pull request
Dec 11, 2023
Similar to openhab#3490, but also for brightness in floats, e.g. `23.0`. Signed-off-by: mueller-ma <[email protected]>
mueller-ma
added a commit
that referenced
this pull request
Dec 16, 2023
Similar to #3490, but also for brightness in floats, e.g. `23.0`. Signed-off-by: mueller-ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging issues with color items I discovered that two SSE events are sent when a slider with a color item is updated.
Item:
Sitemap:
The first event contains a state in the hsb format (
10,10,10), the second events contains the brightness only (10). Parsing an integer as brightness failed and the slider was set to0.IMO an integer in the range
0..100can be considered as brightness.