Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status bar being invisible in chart and image activities #3476

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

maniac103
Copy link
Contributor

Do enableDrawingBehindStatusBar() unconditionally, as otherwise our app bar will be laid out on top of the status bar.

Do enableDrawingBehindStatusBar() unconditionally, as otherwise our app
bar will be laid out on top of the status bar.

Signed-off-by: Danny Baumann <[email protected]>
@mueller-ma
Copy link
Member

I cannot reproduce this issue, but feel free to merge if it fixes it for you.

@maniac103
Copy link
Contributor Author

Maybe I explained the issue poorly. Try opening a ChartActivity and check the status bar contents: are those visible for you? I used to only get a background, but no contents (clock, icons etc.) prior to this patch.

@mueller-ma
Copy link
Member

Try opening a ChartActivity and check the status bar contents: are those visible for you?

Yes, it can see it correctly on 3.7.4-beta.

@maniac103
Copy link
Contributor Author

Just tried with exactly that version and got this:

Screenshot_20230917-153000_openHAB Beta

... so it definitely reproduces the issue. This sounds like an Android version thing then. What version does your device have? Android 13 here.

@SteWers
Copy link

SteWers commented Sep 18, 2023

The issue is present in Android 13, but not in Android 9. App version: 3.7.4-beta

@maniac103
Copy link
Contributor Author

Double checked the change doesn't break anything in Android 9 ... I think this should be safe to merge.

@maniac103 maniac103 merged commit f48ad93 into openhab:main Sep 22, 2023
@maniac103 maniac103 deleted the statusbar-fix branch September 22, 2023 12:52
@SteWers
Copy link

SteWers commented Sep 24, 2023

The last beta works in Android 9 and 13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants