Fix applying first map location #3471
Conversation
If the map isn't loaded yet when the first map widget is bound, the bind attempt for that widget was discarded. Fix this by making sure to apply the widget bind attempt after initially loading the map. While at it, also make sure not to load the map until after the data saver check happened to not cause data transfer before that check. Fixes openhab#3412 Signed-off-by: Danny Baumann <[email protected]>
|
Untested yet, because there's no way to test the Maps SDK without a billed account :-/ |
Signed-off-by: Danny Baumann <[email protected]>
|
The maps key is here https://github.com/openhab/openhab-android/blob/main/.github/workflows/build.yml#L38 but only usable in apps signed by the release key. Some years ago I was able to generate an API key for development in my personal Google account (not a paid account). Did you check if that's still possible? |
|
I think that was the case for me too, but it looks like this isn't possible anymore. At least the SDK guide mentions billing to be a prerequisite. |
|
@mueller-ma While I couldn't test it myself, I'm fairly certain this will fix #3412. My suggestion would be putting this into a beta for an actual live test now, and at some point in the future think about improving the debugging setup, e.g. by sharing a signing certificate we then use when debugging the app, and adding that signing cert to the Google account? |
|
Let's give it a try in the beta version: https://github.com/openhab/openhab-android/releases/tag/3.7.5-beta |
|
I can confirm, it works as intended 👍🏻 |
If the map isn't loaded yet when the first map widget is bound, the bind attempt for that widget was discarded. Fix this by making sure to apply the widget bind attempt after initially loading the map. While at it, also make sure not to load the map until after the data saver check happened to not cause data transfer before that check.
Fixes #3412