Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonos] Add support for Sonos Move #9962

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Conversation

lolodomo
Copy link
Contributor

Fix #9950

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from kgoderis as a code owner January 25, 2021 21:52
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you update the readme as well?

@lolodomo
Copy link
Contributor Author

Readme updated (several models were missing).

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister added enhancement An enhancement or new feature for an existing add-on rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 26, 2021
@cpmeister cpmeister merged commit 3ec5243 into openhab:main Jan 27, 2021
@cpmeister cpmeister added this to the 3.1 milestone Jan 27, 2021
@lolodomo lolodomo deleted the sonos_move branch January 27, 2021 07:31
lsiepel added a commit to lsiepel/openhab-addons that referenced this pull request Feb 9, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
* [sonos] Add support for Sonos Move

Fix openhab#9950 

* README: updated list of supported Sonos models

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: John Marshall <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
* [sonos] Add support for Sonos Move

Fix openhab#9950 

* README: updated list of supported Sonos models

Signed-off-by: Laurent Garnier <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* [sonos] Add support for Sonos Move

Fix openhab#9950 

* README: updated list of supported Sonos models

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sonos] Thing type for Sonos Move
2 participants