Removal of reference to PaperUI #9905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to openhab#8607. In some cases removed information that is actually generic information and should not be in binding readme. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Hilbrand
requested review from
BobRak,
cweitkamp,
DerOetzi,
fruggy83,
gerrieg,
kaikreuzer,
marcelrv,
markus7017,
mgeramb,
mherwege,
ssalonen and
tmrobert8
as code owners
Hilbrand
commented
Jan 21, 2021
| final JsonElement itemLabel = jo.remove("itemLabel"); | ||
| jo.addProperty("itemLabel", groupLabel + "#" + itemLabel.getAsString()); | ||
| } else if (StringUtils.isNotEmpty("groupId")) { | ||
| } else if (groupId != null && !groupId.isEmpty()) { |
There was a problem hiding this comment.
Also removed StringUtils in this class. But this actually looks like a bug.
lsiepel
added a commit
to lsiepel/openhab-addons
that referenced
this pull request
Feb 9, 2021
This reverts commit 8889762.
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
Related to openhab#8607. In some cases removed information that is actually generic information and should not be in binding readme. Signed-off-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: John Marshall <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Related to openhab#8607. In some cases removed information that is actually generic information and should not be in binding readme. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Related to openhab#8607. In some cases removed information that is actually generic information and should not be in binding readme. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8607.
In some cases removed information that is actually generic information and should not be in binding readme.