[velux] Fixed a couple of bugs if the Bridge contains one or more Scenes #9794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
andrewfg
added
bug
fwolter
approved these changes
Jan 13, 2021
|
@fwolter thank you for the merge.
And thank you for the feedback. But the reason for having static loggers is normally that the respective classes have static methods which require logging. I don't know any other way to resolve that. (Do you have suggestions?) |
|
Shame on me, I didn't looked into the code at these places. It's ok to have these static. But I just saw that the JAR got accidentally into this PR. Can you file a follow-up PR to remove it? |
Yes. |
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…nes (openhab#9794) Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: John Marshall <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…nes (openhab#9794) Signed-off-by: Andrew Fiddian-Green <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…nes (openhab#9794) Signed-off-by: Andrew Fiddian-Green <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the following bugs..