Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[irobot] Add command "cleanRegions" to clean specific regions only #9775

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

rimago
Copy link
Contributor

@rimago rimago commented Jan 10, 2021

  • add command: "cleanRegions:<pmapId>;<region_id1>,<region_id2>" to clean only specific regions of a specific map
  • change initiator in the requests from "localApp" to "openhab"
  • add channel last_command to determine the required pmapId and region_ids
  • I also added the RoombaHandlerTest: It is not an origin JUnit-Test, but it was very helpful to test the protocol without openhab. Feel free to remove it, if it does not fulfill your requirements

Signed-off-by: Florian Binder [email protected]

@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Jan 12, 2021
@fwolter
Copy link
Member

fwolter commented Jan 13, 2021

@Sonic-Amiga can you take a look?

Copy link
Contributor

@Sonic-Amiga Sonic-Amiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything bad here. I'm glad that someone is building upon

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 19, 2021
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 22, 2021
@rimago rimago requested a review from cpmeister January 23, 2021 15:45
@cpmeister cpmeister merged commit e4b9593 into openhab:main Jan 26, 2021
@cpmeister cpmeister added this to the 3.1 milestone Jan 26, 2021
lsiepel added a commit to lsiepel/openhab-addons that referenced this pull request Feb 9, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/irobot-9xx-on-openhab/17774/235

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/irobot-9xx-on-openhab/17774/249

themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/edit-item-metadata-gui-vs-commas/128658/1

marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants