-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[irobot] Add command "cleanRegions" to clean specific regions only #9775
Conversation
@Sonic-Amiga can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything bad here. I'm glad that someone is building upon
....binding.irobot/src/main/java/org/openhab/binding/irobot/internal/handler/RoombaHandler.java
Outdated
Show resolved
Hide resolved
...enhab.binding.irobot/src/main/java/org/openhab/binding/irobot/internal/dto/MQTTProtocol.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
....binding.irobot/src/main/java/org/openhab/binding/irobot/internal/handler/RoombaHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Binder <[email protected]>
....binding.irobot/src/main/java/org/openhab/binding/irobot/internal/handler/RoombaHandler.java
Show resolved
Hide resolved
… only (openhab#9775)" This reverts commit e4b9593.
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/irobot-9xx-on-openhab/17774/235 |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/irobot-9xx-on-openhab/17774/249 |
…penhab#9775) Signed-off-by: Florian Binder <[email protected]> Signed-off-by: John Marshall <[email protected]>
…penhab#9775) Signed-off-by: Florian Binder <[email protected]>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/edit-item-metadata-gui-vs-commas/128658/1 |
…penhab#9775) Signed-off-by: Florian Binder <[email protected]>
Signed-off-by: Florian Binder [email protected]