Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tr064] fix parameter patterns #9749

Merged
merged 1 commit into from
Jan 9, 2021
Merged

[tr064] fix parameter patterns #9749

merged 1 commit into from
Jan 9, 2021

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 8, 2021

Signed-off-by: Jan N. Klug [email protected]

Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of an add-on label Jan 8, 2021
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit 673535a into openhab:main Jan 9, 2021
@cweitkamp cweitkamp added this to the 3.1 milestone Jan 9, 2021
@J-N-K J-N-K deleted the tr064-3 branch January 9, 2021 16:39
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: John Marshall <[email protected]>
Copy link

@syntacrsc syntacrsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a RegEx expert but:
does the added regEx pattern allow IP-addresses containing 0?
e.g. 10.0.0.10 ??
shouldn't it be something like
pattern="([0-9]\d{0,2}.){3}[0-9]\d{0,2}(\s*#.)"/>
instead of
pattern="([1-9]\d{0,2}.){3}[1-9]\d{0,2}(\s*#.)"/>

??

@J-N-K
Copy link
Member Author

J-N-K commented Jul 3, 2021

You are right, it's wrong. But something like 010 should not be allowed. So maybe it has to be extended to something like ([1-9]\d{0-2}\.|0\.){3}([1-9]\d{0-2}|0).

thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants