Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openweathermap] Added new supported languages #9717

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

cweitkamp
Copy link
Contributor

  • Added new supported languages

Closes #9695

Signed-off-by: Christoph Weitkamp [email protected]

Signed-off-by: Christoph Weitkamp <[email protected]>
@cweitkamp cweitkamp added the enhancement An enhancement or new feature for an existing add-on label Jan 6, 2021
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

lolodomo commented Jan 6, 2021

Of course, you checked that they are available for the API ?

@cweitkamp
Copy link
Contributor Author

No, I did not. I copied them from https://openweathermap.org/current#multi. And I have to trust it what they are publishing.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

lolodomo commented Jan 6, 2021

Ok, that is what I mean. Perfect.

@cpmeister cpmeister merged commit 6c648c4 into openhab:main Jan 6, 2021
@cpmeister cpmeister added this to the 3.1 milestone Jan 6, 2021
@cweitkamp cweitkamp deleted the feature-9695-owm-languages branch January 7, 2021 05:57
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
Signed-off-by: Christoph Weitkamp <[email protected]>
Signed-off-by: John Marshall <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenWeatherMap] OpenWeatherMap Binding language DA missing
4 participants