[tr064] reduce network load and improve XML handling #9693

J-N-K · 2021-01-04T19:15:22Z

Signed-off-by: Jan N. Klug <[email protected]>

cweitkamp · 2021-01-06T14:36:36Z

Yesterday I installed this version for testing. The reported issue in #9689 did not occur again. Unfortunately the timeout is still there, but not that often - it looks like the new timeout is not taken into account:

2021-01-06 14:57:26.436 [WARN ] [ng.tr064.internal.soap.SOAPConnector] - Failed to get Tr064ChannelConfig{channelType=macOnline, getAction=GetSpecificHostEntry, dataType='boolean, parameter='72:2E:43:A4:44:9E'}: java.util.concurrent.TimeoutException: Total timeout 2000 ms elapsed

Signed-off-by: Jan N. Klug <[email protected]>

J-N-K · 2021-01-06T16:32:32Z

There's two different timeouts, one for SOAP requests and the other for all other HTTP requests. I have now adjusted bothto 5s.

Signed-off-by: Jan N. Klug <[email protected]>

J-N-K · 2021-01-06T17:35:00Z

I also implementing caching for the SOAP requests. Especially for call lists there are many requests which are the same.

...enhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/soap/SOAPConnector.java

cweitkamp · 2021-01-07T20:04:47Z

Looks good so far. No messages in my log anymore for more than twelve hours. Thank you for looking into it.

cweitkamp

LGTM. Thanks. And it is working fine. No more warnings since nearly two days.

cweitkamp · 2021-01-08T19:12:48Z

...enhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/soap/SOAPConnector.java

    private final Logger logger = LoggerFactory.getLogger(SOAPConnector.class);
    private final HttpClient httpClient;
    private final String endpointBaseURL;
    private final SOAPValueConverter soapValueConverter;

+    private final ExpiringCacheMap<SOAPRequest, SOAPMessage> soapMessageCache = new ExpiringCacheMap<>(


Only a minor remark. Why not passing the time value directly like here ? Or use Duration.of() to improve readability.

The stateCache can probably be omitted. Sinc ethe SOAP request to fill it is cached anyway. WDYT?

Yes, we probably could remove that one.

OTOH, it bypasses the construction of the SOAP request and does not add much complexity now that it is here. So I would prefer to leave it in place.

...es/org.openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/util/Util.java

Signed-off-by: Jan N. Klug <[email protected]>

cweitkamp · 2021-01-08T19:34:43Z

I found another occurring message - is this handled differently?

2021-01-08 19:09:02.538 [INFO ] [064.internal.soap.SOAPValueConverter] - Postprocessor processTamListURL failed: Failed to get TAM list from URL https://<IP>:49443/tamcalllist.lua?sid=1156132f00cbd862&tamindex=0
2021-01-08 19:09:02.545 [WARN ] [ng.tr064.internal.soap.SOAPConnector] - Failed to get Tr064ChannelConfig{channelType=tamNewMessages, getAction=GetMessageList, dataType='string, parameter='0'}: failed to transform 'NewURL'

J-N-K · 2021-01-08T19:39:41Z

That request is not cached because there is only one request per answering machine. I wonder if the problem is that two requests are made in the same time (e.g. the request for the TAM list and a call list).

cweitkamp · 2021-01-08T19:42:27Z

But there are two channels available for each TAM: tamEnable_n and tamNewMessages_n.

J-N-K · 2021-01-08T19:47:50Z

True. But „enabled“ is from a regular (cached) soap request (like getting the URL) and only „newMessages“ is an additional HTTP call.

cweitkamp

LGTM. Thanks.

* reduce network load * adjust soap timeout Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: John Marshall <[email protected]>

* reduce network load * adjust soap timeout Signed-off-by: Jan N. Klug <[email protected]>

sheilbronn · 2021-12-18T17:31:49Z

BTW: I still get these messages on OpenHAB 3.2.0~M5 and Fritzbox software release 7.29 irregularly :(

2021-12-18 16:12:28.064 [WARN ] [ng.tr064.internal.soap.SOAPConnector] - Failed to get Tr064ChannelConfig{channelType=tamNewMessages, getAction=GetMessageList, dataType='string, parameter='0'}: failed to transform 'NewURL'
2021-12-18 16:36:54.320 [INFO ] [064.internal.soap.SOAPValueConverter] - Postprocessor processTamListURL failed: Failed to get TAM list from URL https://192.168.178.1:49443/tamcalllist.lua?sid=42b240695a650bbf&tamindex=0
2021-12-18 16:36:54.322 [WARN ] [ng.tr064.internal.soap.SOAPConnector] - Failed to get Tr064ChannelConfig{channelType=tamNewMessages, getAction=GetMessageList, dataType='string, parameter='0'}: failed to transform 'NewURL'
2021-12-18 16:43:00.106 [INFO ] [064.internal.soap.SOAPValueConverter] - Postprocessor processTamListURL failed: Failed to get TAM list from URL https://192.168.178.1:49443/tamcalllist.lua?sid=42b240695a650bbf&tamindex=0
2021-12-18 16:43:00.108 [WARN ] [ng.tr064.internal.soap.SOAPConnector] - Failed to get Tr064ChannelConfig{channelType=tamNewMessages, getAction=GetMessageList, dataType='string, parameter='0'}: failed to transform 'NewURL'
2021-12-18 18:16:23.491 [INFO ] [064.internal.soap.SOAPValueConverter] - Postprocessor processTamListURL failed: Failed to get TAM list from URL https://192.168.178.1:49443/tamcalllist.lua?sid=42b240695a650bbf&tamindex=0
2021-12-18 18:16:23.493 [WARN ] [ng.tr064.internal.soap.SOAPConnector] - Failed to get Tr064ChannelConfig{channelType=tamNewMessages, getAction=GetMessageList, dataType='string, parameter='0'}: failed to transform 'NewURL'
2021-12-18 18:18:27.161 [INFO ] [064.internal.soap.SOAPValueConverter] - Postprocessor processTamListURL failed: Failed to get TAM list from URL https://192.168.178.1:49443/tamcalllist.lua?sid=42b240695a650bbf&tamindex=1
2021-12-18 18:18:27.162 [WARN ] [ng.tr064.internal.soap.SOAPConnector] - Failed to get Tr064ChannelConfig{channelType=tamNewMessages, getAction=GetMessageList, dataType='string, parameter='1'}: failed to transform 'NewURL'```

* reduce network load * adjust soap timeout Signed-off-by: Jan N. Klug <[email protected]>

J-N-K added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Jan 4, 2021

reduce network load

a921aee

Signed-off-by: Jan N. Klug <[email protected]>

J-N-K force-pushed the tr064-2 branch from 3311cd4 to a921aee Compare January 4, 2021 19:17

adjust soap timeout

8ddd9e8

Signed-off-by: Jan N. Klug <[email protected]>

implement more caching

840ba74

Signed-off-by: Jan N. Klug <[email protected]>

cpmeister reviewed Jan 6, 2021

View reviewed changes

...enhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/soap/SOAPConnector.java Show resolved Hide resolved

J-N-K commented Jan 6, 2021

View reviewed changes

...enhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/soap/SOAPConnector.java Show resolved Hide resolved

cpmeister approved these changes Jan 6, 2021

View reviewed changes

J-N-K mentioned this pull request Jan 8, 2021

OH3 tr064 binding stuck in OOM #9745

Closed

cweitkamp reviewed Jan 8, 2021

View reviewed changes

address review comments

815f868

Signed-off-by: Jan N. Klug <[email protected]>

cweitkamp approved these changes Jan 9, 2021

View reviewed changes

cweitkamp merged commit ef87af3 into openhab:main Jan 9, 2021

cweitkamp added this to the 3.1 milestone Jan 9, 2021

J-N-K deleted the tr064-2 branch January 9, 2021 16:39

thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021

[tr064] reduce network load and improve XML handling (openhab#9693)

1db374d

* reduce network load * adjust soap timeout Signed-off-by: Jan N. Klug <[email protected]>

wborn removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Dec 18, 2021

marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022

[tr064] reduce network load and improve XML handling (openhab#9693)

148f12b

* reduce network load * adjust soap timeout Signed-off-by: Jan N. Klug <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tr064] reduce network load and improve XML handling #9693

[tr064] reduce network load and improve XML handling #9693

J-N-K commented Jan 4, 2021

cweitkamp commented Jan 6, 2021

J-N-K commented Jan 6, 2021

J-N-K commented Jan 6, 2021

cweitkamp commented Jan 7, 2021

cweitkamp left a comment

cweitkamp Jan 8, 2021

J-N-K Jan 8, 2021

cweitkamp Jan 8, 2021

J-N-K Jan 8, 2021

cweitkamp commented Jan 8, 2021

J-N-K commented Jan 8, 2021

cweitkamp commented Jan 8, 2021

J-N-K commented Jan 8, 2021

cweitkamp left a comment

sheilbronn commented Dec 18, 2021 •

edited

Loading

[tr064] reduce network load and improve XML handling #9693

[tr064] reduce network load and improve XML handling #9693

Conversation

J-N-K commented Jan 4, 2021

cweitkamp commented Jan 6, 2021

J-N-K commented Jan 6, 2021

J-N-K commented Jan 6, 2021

cweitkamp commented Jan 7, 2021

cweitkamp left a comment

Choose a reason for hiding this comment

cweitkamp Jan 8, 2021

Choose a reason for hiding this comment

J-N-K Jan 8, 2021

Choose a reason for hiding this comment

cweitkamp Jan 8, 2021

Choose a reason for hiding this comment

J-N-K Jan 8, 2021

Choose a reason for hiding this comment

cweitkamp commented Jan 8, 2021

J-N-K commented Jan 8, 2021

cweitkamp commented Jan 8, 2021

J-N-K commented Jan 8, 2021

cweitkamp left a comment

Choose a reason for hiding this comment

sheilbronn commented Dec 18, 2021 • edited Loading

sheilbronn commented Dec 18, 2021 •

edited

Loading