Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modbus] itests: Fix testRefreshOnData #9668

Merged
merged 3 commits into from
Jan 6, 2021
Merged

[modbus] itests: Fix testRefreshOnData #9668

merged 3 commits into from
Jan 6, 2021

Conversation

ssalonen
Copy link
Contributor

@ssalonen ssalonen commented Jan 3, 2021

Resolves #9617

Signed-off-by: Sami Salonen [email protected]

fwolter
fwolter requested changes Jan 3, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

...nding.modbus.tests/src/main/java/org/openhab/binding/modbus/tests/ModbusDataHandlerTest.java Outdated Show resolved Hide resolved
@ssalonen
Copy link
Contributor Author

ssalonen commented Jan 6, 2021 •
edited
Loading

Jenkins:

[ERROR] Failed to execute goal biz.aQute.bnd:bnd-testing-maven-plugin:5.1.2:testing (default) on project org.openhab.binding.astro.tests: 20 errors found -> [Help 1]
[ERROR] Failed to execute goal biz.aQute.bnd:bnd-testing-maven-plugin:5.1.2:testing (default) on project org.openhab.binding.avmfritz.tests: 18 errors found -> [Help 1]

which leads to

[INFO] openHAB Add-ons :: Integration Tests :: Modbus Binding Tests SKIPPED

I can see errors like

[ERROR] Error   : Cannot find /error/junit-jupiter-params;version=[5.6.2,5.6.3) Not found in [bnd-cache [/home/jenkins/jenkins-agent1/workspace/PR-openHAB-Addons@2/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/5.1.2/bnd-cache r/w=false], org.openhab.core.bom.runtime-index [/home/jenkins/jenkins-agent1/workspace/PR-openHAB-Addons@2/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/5.1.2/org.openhab.core.bom.runtime-index r/w=false], org.openhab.core.bom.test-index [/home/jenkins/jenkins-agent1/workspace/PR-openHAB-Addons@2/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/5.1.2/org.openhab.core.bom.test-index r/w=false], org.openhab.core.bom.openhab-core-index [/home/jenkins/jenkins-agent1/workspace/PR-openHAB-Addons@2/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/5.1.2/org.openhab.core.bom.openhab-core-index r/w=false], self [/home/jenkins/jenkins-agent1/workspace/PR-openHAB-Addons@2/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/5.1.2/self r/w=false], openHAB Add-ons :: Integration Tests :: Astro Binding Tests [org.openhab.binding.astro.tests,org.lastnpe.eea:eea-all,org.openhab.binding.astro r/w=false]]

@ssalonen ssalonen added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 6, 2021
@fwolter fwolter added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 6, 2021
@fwolter fwolter merged commit 4e1d49c into openhab:main Jan 6, 2021
@fwolter fwolter added the test label Jan 6, 2021
@fwolter fwolter added this to the 3.1 milestone Jan 6, 2021
@wborn wborn mentioned this pull request Jan 18, 2021
Closed
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@ssalonen @themillhousegroup
[modbus] itests: Fix testRefreshOnData (openhab#9668)
1673618 
* [modbus] itests: Fix testRefreshOnData

Resolves openhab#9617

Signed-off-by: Sami Salonen <[email protected]>

* [modbus] using default timeouts for waitForAssert

Signed-off-by: Sami Salonen <[email protected]>

* [modbus] mvn spotless:apply

Signed-off-by: Sami Salonen <[email protected]>
Signed-off-by: John Marshall <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@ssalonen @thinkingstone
[modbus] itests: Fix testRefreshOnData (openhab#9668)
3a0401f 
* [modbus] itests: Fix testRefreshOnData

Resolves openhab#9617

Signed-off-by: Sami Salonen <[email protected]>

* [modbus] using default timeouts for waitForAssert

Signed-off-by: Sami Salonen <[email protected]>

* [modbus] mvn spotless:apply

Signed-off-by: Sami Salonen <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@ssalonen
[modbus] itests: Fix testRefreshOnData (openhab#9668)
aa1c9bb 
* [modbus] itests: Fix testRefreshOnData

Resolves openhab#9617

Signed-off-by: Sami Salonen <[email protected]>

* [modbus] using default timeouts for waitForAssert

Signed-off-by: Sami Salonen <[email protected]>

* [modbus] mvn spotless:apply

Signed-off-by: Sami Salonen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[modbus] Test ModbusDataHandlerTest#testRefreshOnData unstable
2 participants
@ssalonen @fwolter