Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[remoteopenhab] Consider the remote item pattern formatter #9657

Merged
merged 3 commits into from
Jan 4, 2021
Merged

[remoteopenhab] Consider the remote item pattern formatter #9657

merged 3 commits into from
Jan 4, 2021

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jan 2, 2021 •
edited
Loading

Fix #9645

Signed-off-by: Laurent Garnier [email protected]

@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Jan 3, 2021
@lolodomo
Copy link
Contributor Author

lolodomo commented Jan 3, 2021 •
edited
Loading

@cpmeister : do you think I should remove List<ChannelType> channelTypes ? I kept it only to have the method getChannelTypes simple (just returning it). But I could certainly build the returned value for getChannelTypes using my new hashmap. It would be done with less performance. But it would avoid having each channel type stored twice.

@cpmeister
Copy link
Contributor

I don't think it matters all that much. As long as the code is simple and performant.

@cpmeister cpmeister merged commit a63acf0 into openhab:main Jan 4, 2021
@cpmeister cpmeister added this to the 3.1 milestone Jan 4, 2021
@lolodomo lolodomo deleted the remoteoh_pattern branch May 13, 2021 09:32
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@lolodomo @thinkingstone
[remoteopenhab] Consider the remote item pattern formatter (openhab#9657
484e254 
)

* [remoteopenhab] Consider the remote item pattern formatter

Fux openhab#9645
* Review comment: use computeIfAbsent

Signed-off-by: Laurent Garnier <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@lolodomo
[remoteopenhab] Consider the remote item pattern formatter (openhab#9657
f2c4bac 
)

* [remoteopenhab] Consider the remote item pattern formatter

Fux openhab#9645
* Review comment: use computeIfAbsent

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[remoteopenhab] Considering the remote item pattern formatter
2 participants
@lolodomo @cpmeister