Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tr064] fix wanBlockByIP channel and improvements to paramater handling #9655

Merged
merged 1 commit into from
Jan 3, 2021

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 2, 2021

  • fix wanBlockByIP channel
  • allow comments in parameter lists
  • fix compiler warnings

Signed-off-by: Jan N. Klug [email protected]

- fix wanBlockByIP channel
- allow comments in parameter lists
- fix compiler warnings

Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K added bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on labels Jan 2, 2021
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit b4b8dd2 into openhab:main Jan 3, 2021
@cpmeister cpmeister added this to the 3.1 milestone Jan 3, 2021
@J-N-K J-N-K deleted the tr064 branch January 3, 2021 07:37
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…ng (openhab#9655)

- fix wanBlockByIP channel
- allow comments in parameter lists
- fix compiler warnings

Signed-off-by: Jan N. Klug <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…ng (openhab#9655)

- fix wanBlockByIP channel
- allow comments in parameter lists
- fix compiler warnings

Signed-off-by: Jan N. Klug <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants