[js] Added 'ConfigOptionProvider' to provide filenames ending with '.js' in Profile configuration #9646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweitkamp
added
the
enhancement
cweitkamp
changed the title
J-N-K
requested changes
Jan 2, 2021
| @@ -52,7 +51,7 @@ | |||
| @NonNullByDefault({}) | |||
There was a problem hiding this comment.
This annotation is wrong. l. 75 sets it to null. (also above)
There was a problem hiding this comment.
Absolutely. I changed it.
J-N-K
approved these changes
Jan 3, 2021
|
Can you resolve conflicts? |
… Profile configuration Signed-off-by: Christoph Weitkamp <[email protected]>
Signed-off-by: Christoph Weitkamp <[email protected]>
cweitkamp
force-pushed
the
feature-js-profile-config-options-provider
branch
from
839f3a9 to
8b028d3
Compare
|
Rebase done. |
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Feb 2, 2021
…js' in Profile configuration (openhab#9646) * Added ConfigOptionProvider to provide file names ending with '.js' in Profile configuration Signed-off-by: Christoph Weitkamp <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…js' in Profile configuration (openhab#9646) * Added ConfigOptionProvider to provide file names ending with '.js' in Profile configuration Signed-off-by: Christoph Weitkamp <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…js' in Profile configuration (openhab#9646) * Added ConfigOptionProvider to provide file names ending with '.js' in Profile configuration Signed-off-by: Christoph Weitkamp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christoph Weitkamp [email protected]