[remoteopenhab] Handle IllegalArgumentException when building channels #9638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Garnier <[email protected]>
|
The build in Feed binding integration tests. No link with my PR. |
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
openhab#9638) Signed-off-by: Laurent Garnier <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
openhab#9638) Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the failing of the binding reported by a user on the forum because he has several items with the same name on his remote server. I don't know how it is possible to define several items with the same name (I was not able to do it) but by the way, this PR makes sure to catch this exception (IllegalArgumentException), log a message that should help the user, and put the thing to OFFLINE in case the creation of the channels is failing due to this exception.
Signed-off-by: Laurent Garnier [email protected]