Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ecobee] Fixed actions broken by recent PR #9632

Merged
merged 1 commit into from
Jan 2, 2021

Conversation

mhilbush
Copy link
Contributor

@mhilbush mhilbush commented Jan 1, 2021

Mistakenly removed the entire getServices method. 😦

Fixes #9630

Signed-off-by: Mark Hilbush [email protected]

Signed-off-by: Mark Hilbush <[email protected]>
@mhilbush mhilbush added bug An unexpected problem or unintended behavior of an add-on critical labels Jan 1, 2021
@morph166955
Copy link
Contributor

Confirmed, error is no longer throwing.

Copy link
Contributor

@t2000 t2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@cpmeister cpmeister merged commit 10d2ab2 into openhab:main Jan 2, 2021
@cpmeister cpmeister added this to the 3.1 milestone Jan 2, 2021
@mhilbush mhilbush deleted the ecobee-fix-actions branch January 3, 2021 14:38
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ecobee] 'setHold' is not a member of 'org.openhab.core.thing.binding.ThingActions'
4 participants