[nikobus] open connection on refresh even if no modules exist #9603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitwouter
force-pushed
the
nikobus_buttons_without_modules
branch
2 times, most recently
from
38d9c9e to
4cf0bed
Compare
Signed-off-by: Wouter Denayer <[email protected]>
gitwouter
force-pushed
the
nikobus_buttons_without_modules
branch
from
4cf0bed to
0baf8e5
Compare
fwolter
requested changes
Dec 31, 2020
...nikobus/src/main/java/org/openhab/binding/nikobus/internal/handler/NikobusPcLinkHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Wouter Denayer <[email protected]>
fwolter
requested changes
Dec 31, 2020
Signed-off-by: Wouter Denayer <[email protected]>
crnjan
added
rebuild
cpmeister
reviewed
Jan 2, 2021
...nikobus/src/main/java/org/openhab/binding/nikobus/internal/handler/NikobusPcLinkHandler.java
Outdated
Show resolved
Hide resolved
|
You need to sign-off your commits. See https://www.openhab.org/docs/developer/contributing.html#sign-your-work The necessary commands are listed when you click on "Details" at the DCO check below. |
either. Signed-off-by: Wouter Denayer <[email protected]>
gitwouter
force-pushed
the
nikobus_buttons_without_modules
branch
from
720409b to
8021ce1
Compare
cpmeister
approved these changes
Jan 4, 2021
fwolter
approved these changes
Jan 4, 2021
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Feb 2, 2021
…b#9603) * open connection on refresh even if no modules exist Signed-off-by: Wouter Denayer <[email protected]> * ran mvn spotless:apply Signed-off-by: Wouter Denayer <[email protected]> * removed unnecessary file Signed-off-by: Wouter Denayer <[email protected]> * returning when the connection is offline since following code won't work either. Signed-off-by: Wouter Denayer <[email protected]> Co-authored-by: Wouter Denayer <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…b#9603) * open connection on refresh even if no modules exist Signed-off-by: Wouter Denayer <[email protected]> * ran mvn spotless:apply Signed-off-by: Wouter Denayer <[email protected]> * removed unnecessary file Signed-off-by: Wouter Denayer <[email protected]> * returning when the connection is offline since following code won't work either. Signed-off-by: Wouter Denayer <[email protected]> Co-authored-by: Wouter Denayer <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…b#9603) * open connection on refresh even if no modules exist Signed-off-by: Wouter Denayer <[email protected]> * ran mvn spotless:apply Signed-off-by: Wouter Denayer <[email protected]> * removed unnecessary file Signed-off-by: Wouter Denayer <[email protected]> * returning when the connection is offline since following code won't work either. Signed-off-by: Wouter Denayer <[email protected]> Co-authored-by: Wouter Denayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wouter Denayer [email protected]
open connection on refresh even if no modules exist
currently, when no modules are defined the connection to nikobus is not opened and therefore the button presses are not detected.