Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WlanThermo] Add support for new ESP32-powered devices [V2.5.x] #9580

Closed
wants to merge 4 commits into from

Conversation

CSchlipp
Copy link
Contributor

@CSchlipp CSchlipp commented Dec 29, 2020

This PR adds support for the new Nano V3, Mini V2 (with ESP32-Upgrade), and Link V1 devices.

The API of these hardware versions has changed compared to the previous devices, but is the same for the whole new platform (thus named "esp32"). This commit follows the same approach as the initial contribution and contains auto-generated classes for parsing the new JSON output.

The thing description xml has been spit up to different files to ease the future development.
No further changes to existing things, thus backwards compatible.

Configuration of different thing types has been merged to avoid duplicate code.

PR to V3.x via PR #9579 (same changes)

Signed-off-by: Christian Schlipp <[email protected]>
Change logs to distinguish between different things

Signed-off-by: Christian Schlipp <[email protected]>
Signed-off-by: Christian Schlipp <[email protected]>
Signed-off-by: Christian Schlipp <[email protected]>
@CSchlipp CSchlipp changed the title Wlan thermo binding [WlanThermo] Add support for new ESP32-powered devices [V2.5.x] Dec 29, 2020
@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Dec 29, 2020
@CSchlipp
Copy link
Contributor Author

Jenkins build got cancelled before it reached WlanThermo Binding, don't know why...

@fwolter
Copy link
Member

fwolter commented Dec 31, 2020

OH 2.5.x will only receive critical fixes. So, this will probably not merged... Please also file the 2.5.x PR only if the OH 3.x PR has been merged.

@CSchlipp
Copy link
Contributor Author

OH 2.5.x will only receive critical fixes. So, this will probably not merged... Please also file the 2.5.x PR only if the OH 3.x PR has been merged.

Okay - then I'll close this for now.

@CSchlipp CSchlipp closed this Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants