[roku] binding - initial implementation

[mlobstein]

This PR is the initial implementation of a new binding to control Roku Streaming Media Players & Roku TVs.

Test build available here:
https://github.com/mlobstein/mlobstein-beta-test/raw/master/org.openhab.binding.roku-3.1.0-SNAPSHOT.jar
https://github.com/mlobstein/mlobstein-beta-test/raw/master/org.openhab.binding.roku-3.1.0-SNAPSHOT-sources.jar

[Skinah]

I'll post some tips whilst you wait for someone to do a review.

In your roku.xml file you have channels that are not camelCase.

active_app should become activeApp which will mean multiple files including the readme need to be updated. Apply this to all your channels.

[Skinah]

catch (RokuHttpException e) {
logger.debug("Unable to launch app on Roku, appId: {}, Exception: {}", command.toString(),
e.getMessage());
updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR);
}

Remove the logger.debug line and instead just put the message into the ThingStatus

updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, "Enter a nice friendly string of text here.");

[mlobstein]

updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, "Enter a nice friendly string of text here.");

Thanks, I updated the channel names. I think it is OK to leave off the exception message from the ThingStatusDetail. This exception is caused by a communication failure and in that situation the exception message will not provide anything useful to the user.

[morph166955]

I'm going to play devils advocate for a second (because I can totally make a case in both directions). Why should the Roku get a binding? The new HTTP binding works really well with the Roku's with very minimal effort. I posted an example at https://community.openhab.org/t/roku-support-on-oh3-using-http-binding/110533 a few days back. What will this binding bring that the HTTP binding is unable to provide?

[mlobstein]

What will this binding bring that the HTTP binding is unable to provide?

Generally speaking when compared to using the HTTP binding to scrape an endpoint, a dedicated binding will provide a more robust implementation. For roku, this binding provides device discovery, a dynamically updated drop-down to launch installed apps, status channels that update when a stream is playing (play state, elapsed time & total time) and a drop down with available remote button commands (filtered based on standalone roku vs roku tv). Also to speed the development of future improvements, all available xml data elements from the api are mapped in the dto objects.

[Skinah]

What will this binding bring that the HTTP binding is unable to provide?

A) If someone is willing to build and maintain (and review it) it that is not "you" then why care? OP, Thank you for your work.
B) I always apricate it when I don't have to open up yet another API or search a forum where half the posts have half baked solutions to sort through.
C) Other projects have it so why not us? https://www.home-assistant.io/integrations/roku/ I don't like openHAB slipping behind even if it is only in 1 area, so lets encourage new contributors and make them feel valued.

Sorry I know you were playing Devils Advocate but that hits a raw nerve for me.

For the record I don't use Roku and have no intension of doing so, but good to know it is there.

[Hilbrand]

LGTM

[cpmeister]

LGTM

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/roku-support-on-oh3-using-http-binding/110533/11