Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smhi] Add aggregated channels for daily forecast. #9387

Merged
merged 2 commits into from
Dec 22, 2020

Conversation

pacive
Copy link
Member

@pacive pacive commented Dec 15, 2020

Also updates to use Optionals instead of @Nullables, and add unit tests

Signed-off-by: Anders Alfredsson [email protected]

Also updates to use Optionals instead of @nullables, and add unit tests

Signed-off-by: Anders Alfredsson <[email protected]>
@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Dec 15, 2020
@fwolter fwolter self-assigned this Dec 15, 2020
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As OH3 is already feature-freezed, your PR will be merged as soon as OH3 is released. Your changes will go into OH3.1, then.

@fwolter fwolter added this to the 3.1 milestone Dec 16, 2020
@cpmeister cpmeister merged commit 393ae49 into openhab:main Dec 22, 2020
@pacive pacive deleted the smhi-aggregate-channels branch December 28, 2020 16:54
seaside1 pushed a commit to seaside1/openhab-addons that referenced this pull request Dec 28, 2020
* Add aggregated channels for daily forecast.

Also updates to use Optionals instead of @nullables, and add unit tests
* Revert unsing explicit unit definition

Signed-off-by: Anders Alfredsson <[email protected]>
seaside1 pushed a commit to seaside1/openhab-addons that referenced this pull request Dec 28, 2020
* Add aggregated channels for daily forecast.

Also updates to use Optionals instead of @nullables, and add unit tests
* Revert unsing explicit unit definition

Signed-off-by: Anders Alfredsson <[email protected]>
Signed-off-by: Joseph Hagberg <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* Add aggregated channels for daily forecast.

Also updates to use Optionals instead of @nullables, and add unit tests
* Revert unsing explicit unit definition

Signed-off-by: Anders Alfredsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants