[chromecast] Initialize connection to devices asynchronously #9228
Conversation
| scheduler.submit(() -> { | ||
| // initialize connection to devices asynchronously | ||
| Coordinator localCoordinator = coordinator; | ||
| if (localCoordinator != null && (!localCoordinator.chromeCast.getAddress().equals(ipAddress) | ||
| || localCoordinator.chromeCast.getPort() != config.port)) { | ||
| localCoordinator.destroy(); | ||
| localCoordinator = coordinator = null; | ||
| } | ||
|
|
||
| if (localCoordinator == null) { | ||
| ChromeCast chromecast = new ChromeCast(ipAddress, config.port); | ||
| localCoordinator = new Coordinator(this, thing, chromecast, config.refreshRate, audioHTTPServer, | ||
| callbackUrl); | ||
| localCoordinator.initialize(); | ||
| coordinator = localCoordinator; | ||
| } | ||
| }); |
There was a problem hiding this comment.
I think quickly cycling the handler (initialize->dispose->initialize) would cause multiple Coordinator instances to be created simultaneously and also lose track of one of them.
There was a problem hiding this comment.
Okay. Calling the coordinator.initialize() method asynchronously and keep the instance creating like before should work either.
There was a problem hiding this comment.
Only if coordinator.initialize() is synchronized along with coordinator.destroy() as well as adding an early exit in coordinator.initialize() if coordinator.destroy() was called first.
I think that would make it thread safe.
There was a problem hiding this comment.
@cweitkamp Do you have this PR still on your radar?
There was a problem hiding this comment.
@kaikreuzer Thanks for the reminder. I updated the PR with the suggested solution above.
fwolter
added
the
awaiting feedback
Signed-off-by: Christoph Weitkamp <[email protected]>
cweitkamp
force-pushed
the
bugfix-chromecast-initialize
branch
from
980e97e to
d629b55
Compare
kaikreuzer
removed
the
awaiting feedback
kaikreuzer
added
the
enhancement
Signed-off-by: Christoph Weitkamp <[email protected]> Signed-off-by: John Marshall <[email protected]>
Signed-off-by: Christoph Weitkamp <[email protected]>
Signed-off-by: Christoph Weitkamp <[email protected]>
Signed-off-by: Christoph Weitkamp <[email protected]>
Signed-off-by: Christoph Weitkamp [email protected]