[bluetooth.bluegiga] Add characteristic notification support #9067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2020 15:25
Also fixed bluegiga initialize/dispose bugs. Signed-off-by: Connor Petty <[email protected]>
Signed-off-by: Connor Petty <[email protected]>
cpmeister
added
awaiting other PR
Signed-off-by: Connor Petty <[email protected]>
cpmeister
added
enhancement
|
build failure unrelated |
|
... but it fails on some bluetooth classes. Might #9064 have introduced these compilation errors? |
|
oof, somehow missed that. I expected the first failure to stop the build. I'll make a fix for the build |
|
Looks like the compilation errors came from the new bluetooth.generic binding. The null checker got a little overzealous, I've create a fix for it. #9115 |
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
…#9067) * Add support for characteristic notifications. * Also fixed bluegiga initialize/dispose bugs. Signed-off-by: Connor Petty <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…#9067) * Add support for characteristic notifications. * Also fixed bluegiga initialize/dispose bugs. Signed-off-by: Connor Petty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My test system for OH3 only uses bluegiga so I had to implement the missing notification feature as well as fix an annoying bug that prevented the bluegiga binding from starting correctly.
This PR requires #9064 to be merged first.