[plugwise] Use ThingHandlerService for discovery #9041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the PlugwiseHandlerFactory code so it no longer needs to register and keep track of a discovery service for each bridge. Also contains a few other improvements: * fix lastRequest timestamp not updated when sending messages to discover node properties * use java.time Duration and Instant * use List.of, Set.of * remove redundant null suppression because of EEAs Signed-off-by: Wouter Born <[email protected]>
wborn
force-pushed
the
plugwise-thinghandlerservice
branch
from
9ad4395 to
14080fa
Compare
wborn
removed
the
enhancement
cpmeister
approved these changes
Nov 15, 2020
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
This simplifies the PlugwiseHandlerFactory code so it no longer needs to register and keep track of a discovery service for each bridge. Also contains a few other improvements: * fix lastRequest timestamp not updated when sending messages to discover node properties * use java.time Duration and Instant * use List.of, Set.of * remove redundant null suppression because of EEAs Signed-off-by: Wouter Born <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
This simplifies the PlugwiseHandlerFactory code so it no longer needs to register and keep track of a discovery service for each bridge. Also contains a few other improvements: * fix lastRequest timestamp not updated when sending messages to discover node properties * use java.time Duration and Instant * use List.of, Set.of * remove redundant null suppression because of EEAs Signed-off-by: Wouter Born <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the PlugwiseHandlerFactory code so it no longer needs to register and keep track of a discovery service for each bridge.
Also contains a few other improvements: