[avmfritz] Avoid a hidden NPE when getIdentifier() of an uninitialized ThingHandler is called #9040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler is colled Signed-off-by: Christoph Weitkamp <[email protected]>
Signed-off-by: Christoph Weitkamp <[email protected]>
cweitkamp
added
the
bug
|
Can be backported to OH 2.5.x, if possible. |
kaikreuzer
reviewed
Nov 15, 2020
...z/src/main/java/org/openhab/binding/avmfritz/internal/handler/AVMFritzBaseBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Christoph Weitkamp <[email protected]>
Bushido76
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
The hidden NPE was initially traced down and reported by me as it lead to various instabilities in Thing handling. The correction was discussed with Christoph and applied by him. The binding - with all corrections applied - is running on my local OH3 instance since yesterday noon and the binding is behaving much more reliably since.
kaikreuzer
approved these changes
Nov 16, 2020
I'm afraid cherry-picking results in a merge conflict in the imports of the Powerline handler class. |
|
Okay, see #9043. |
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
…d ThingHandler is called (openhab#9040) * Avoid a hidden NPE when getIdentifier() of an uninitialized ThingHandler is called * Fixed Powerline546EHandler Signed-off-by: Christoph Weitkamp <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…d ThingHandler is called (openhab#9040) * Avoid a hidden NPE when getIdentifier() of an uninitialized ThingHandler is called * Fixed Powerline546EHandler Signed-off-by: Christoph Weitkamp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getIdentifier()of an uninitializedThingHandleris calledSigned-off-by: Christoph Weitkamp [email protected]