Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[neeo] fix ClassNotFoundException and switch to constructor injection #9006

Merged
merged 5 commits into from
Nov 14, 2020
Merged

[neeo] fix ClassNotFoundException and switch to constructor injection #9006

merged 5 commits into from
Nov 14, 2020

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Nov 11, 2020

Fixes #8984

Signed-off-by: Jan N. Klug [email protected]

@J-N-K J-N-K added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. work in progress A PR that is not yet ready to be merged labels Nov 11, 2020
J-N-K added 2 commits November 13, 2020 19:28
@J-N-K
additional logging
4ff53a2 
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K
better handling of invalid URIs
f767557 
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K changed the title [WIP][neeo] fix ClassNotFoundException and switch to constructor injection [neeo] fix ClassNotFoundException and switch to constructor injection Nov 14, 2020
@J-N-K J-N-K added community approved and removed additional testing preferred The change works for the pull request author. A test from someone else is preferred though. work in progress A PR that is not yet ready to be merged labels Nov 14, 2020
@J-N-K
spotless fix
afae826 
Signed-off-by: Jan N. Klug <[email protected]>
@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Nov 14, 2020
@J-N-K
Copy link
Member Author

J-N-K commented Nov 14, 2020

Again the tado library...

wborn
wborn approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wborn wborn merged commit 1073f00 into openhab:main Nov 14, 2020
@wborn wborn mentioned this pull request Nov 14, 2020
Closed
@cpmeister cpmeister added this to the 3.0.0.M3 milestone Nov 16, 2020
@J-N-K J-N-K mentioned this pull request Dec 4, 2020
Merged
boehan pushed a commit to boehan/openhab-addons that referenced this pull request Apr 12, 2021
@J-N-K @boehan
[neeo] fix ClassNotFoundException and switch to constructor injection (…
fc0a860 
…openhab#9006)

Signed-off-by: Jan N. Klug <[email protected]>
@mhilbush mhilbush mentioned this pull request Dec 4, 2021
Closed
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@J-N-K
[neeo] fix ClassNotFoundException and switch to constructor injection (…
5153917 
…openhab#9006)

Signed-off-by: Jan N. Klug <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on community approved
Projects
None yet
Milestone
3.0.0.M3
Development

Successfully merging this pull request may close these issues.

[neeo] Can Not Add Brain - OH3
3 participants
@J-N-K @wborn @cpmeister