Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miio] Fix handling commands with curly brackets #8897

Merged
merged 1 commit into from
Oct 30, 2020
Merged

[miio] Fix handling commands with curly brackets #8897

merged 1 commit into from
Oct 30, 2020

Conversation

marcelrv
Copy link
Contributor

Signed-off-by: Marcel Verpaalen [email protected]

@marcelrv marcelrv requested a review from cpmeister October 29, 2020 10:30
@marcelrv marcelrv added the bug An unexpected problem or unintended behavior of an add-on label Oct 29, 2020
@marcelrv
Copy link
Contributor Author

Fixing issue from forum for Vacuum 1C STYTJ01ZHM (dreame.vacuum.mc1808)
https://community.openhab.org/t/problem-with-miio-binding-for-vacuum-1c-stytj01zhm-dreame-vacuum-mc1808/102631/27

@cpmeister cpmeister added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 29, 2020
@cpmeister
Copy link
Contributor

Well somehow the TADO binding broke, but it was due to some dependency issue unrelated to this PR.

@cpmeister cpmeister merged commit 9a5832a into openhab:main Oct 30, 2020
@cpmeister cpmeister modified the milestones: 2.5.10, 3.0.0.M2 Oct 30, 2020
@J-N-K
Copy link
Member

J-N-K commented Oct 30, 2020

@kaikreuzer or @wborn can you restart Jenkins/clear cache? It seems to have problems picking up the dependencies I uploaded some days ago. It builds fine locally and also succeeded once on Jenkins.

@kaikreuzer
Copy link
Member

You mean

Failure to find org.openhab.binding.tado:api-client:jar:1.4.1 in https://openhab.jfrog.io/openhab/libs-release

?
This looks rather like an issue with Artifactory, not Jenkins: https://openhab.jfrog.io/openhab/libs-release/org/openhab/binding/tado/ gave me a 404.
I just logged in to Artifactory as an admin and now suddenly I see the content at that url - so I'd assume that it is solved now.

@marcelrv marcelrv deleted the miio-FixCommandSending branch October 30, 2020 07:47
@J-N-K
Copy link
Member

J-N-K commented Oct 30, 2020

That‘s very strange, because in the tado-PR one Build succeeed and failed for another reason. Thanks for having a Look.

marcelrv added a commit to marcelrv/openhab-addons that referenced this pull request Oct 30, 2020
@marcelrv
[miio] Fix handling commands with curly brackets (openhab#8897)
f5fba45 
Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv marcelrv mentioned this pull request Oct 30, 2020
Merged
boehan pushed a commit to boehan/openhab-addons that referenced this pull request Apr 12, 2021
@marcelrv @boehan
[miio] Fix handling commands with curly brackets (openhab#8897)
ab1250c 
Signed-off-by: Marcel Verpaalen <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@marcelrv
[miio] Fix handling commands with curly brackets (openhab#8897)
66ff4ca 
Signed-off-by: Marcel Verpaalen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.0.0.M2
Development

Successfully merging this pull request may close these issues.
4 participants
@marcelrv @cpmeister @J-N-K @kaikreuzer