[hue] Added channel to enable / disable a motion sensor #8721
Conversation
cweitkamp
added
the
enhancement
| case CHANNEL_ENABLED: | ||
| configUpdate.setOn(OnOffType.ON.equals(command)); | ||
| break; | ||
| } |
There was a problem hiding this comment.
For other channels, I think you have to call the parent class (which handle few other channels).
There was a problem hiding this comment.
On the first glance, yes, but currently the presence sensor only has read-only channels thus no command has to be handled except this one.
| break; | ||
| } | ||
|
|
||
| hueBridge.updateSensorConfig(sensor, configUpdate); |
There was a problem hiding this comment.
It should be moved in your switch case.
|
@cweitkamp : can you please have a look to the code of the parent class, I think we have a useless test at this line: |
|
@lolodomo Thanks for your comments. I saw the superfluous check and thought about an improvement too. Problem is that |
|
Looks like you need to run spotless. |
Signed-off-by: Christoph Weitkamp <[email protected]>
Signed-off-by: Christoph Weitkamp <[email protected]>
cweitkamp
force-pushed
the
feature-8389-hue-sensor-deactivation
branch
from
e074c52 to
9137064
Compare
* Added channel to activate/deactivate a motion sensor * Applied spotless Signed-off-by: Christoph Weitkamp <[email protected]>
* Added channel to activate/deactivate a motion sensor * Applied spotless Signed-off-by: Christoph Weitkamp <[email protected]>
Added channel to enable / disable a motion sensor
Closes #8389
Signed-off-by: Christoph Weitkamp [email protected]