Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the default configurations #8696

Closed
wants to merge 1 commit into from
Closed

Corrected the default configurations #8696

wants to merge 1 commit into from

Conversation

JueBag
Copy link

@JueBag JueBag commented Oct 8, 2020

According the comments DEFAULT_NUMERIC, DEFAULT_QUANTIFIABLE config should have 5 archives, the #4 was missing. Additionally the ConsolFunction changed in the DEFAULT_QUANTIFIABLE.
The DEFAULT_OTHER config had false computed archives.

Signed-off-by: Jürgen Baginski [email protected]

According the comments DEFAULT_NUMERIC, DEFAULT_QUANTIFIABLE config should have 5 archives, the #4 was missing. Additionally the ConsolFunction changed in the DEFAULT_QUANTIFIABLE.
The DEFAULT_OTHER config had false computed archives.




Signed-off-by: Jürgen Baginski [email protected]
@JueBag JueBag requested a review from a team as a code owner October 8, 2020 14:16
@Hilbrand
Copy link
Member

Hilbrand commented Oct 8, 2020

Please don't make branches on this repository. Please open a new pull request based on your own fork.

@Hilbrand Hilbrand closed this Oct 8, 2020
@Hilbrand Hilbrand deleted the JueBag-patch-1 branch October 8, 2020 14:20
@TravisBuddy
Copy link

TravisBuddy commented Oct 8, 2020

Hey @JueBag,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 22e786d0-09a3-11eb-b9d6-41d4da7e5060

@kaikreuzer
Copy link
Member

@Hilbrand I think this is what Github does automatically when the online editor is used (see also the README updates).
I think that is ok for these small PRs and we can easily delete the branches when the PR is merged/closed.

@kaikreuzer kaikreuzer restored the JueBag-patch-1 branch October 8, 2020 20:14
@kaikreuzer kaikreuzer reopened this Oct 8, 2020
@kaikreuzer kaikreuzer closed this Oct 8, 2020
@kaikreuzer kaikreuzer deleted the JueBag-patch-1 branch October 8, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants