Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' #7737

Merged
merged 1 commit into from
May 26, 2020
Merged

[dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' #7737

merged 1 commit into from
May 26, 2020

Conversation

lolodomo
Copy link
Contributor

Relative to #7722

Signed-off-by: Laurent Garnier <[email protected]

@lolodomo lolodomo requested a review from RSStephens as a code owner May 22, 2020 10:54
RSStephens
RSStephens approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@RSStephens RSStephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@lolodomo lolodomo changed the title [dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' [WIP][dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' May 23, 2020
@openhab openhab deleted a comment from TravisBuddy May 25, 2020
@openhab openhab deleted a comment from TravisBuddy May 25, 2020
@lolodomo lolodomo force-pushed the dscalarm_ioutils branch from 6583519 to 71de031 Compare May 25, 2020 15:21
@lolodomo lolodomo changed the title [WIP][dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' [dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' May 25, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@lolodomo
[dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils'
b779b01 
Relative to openhab#7722

Let the socket closure close the in/out streams

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo force-pushed the dscalarm_ioutils branch from 71de031 to b779b01 Compare May 25, 2020 18:25
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@J-N-K J-N-K merged commit a44aaaa into openhab:2.5.x May 26, 2020
@lolodomo lolodomo deleted the dscalarm_ioutils branch May 26, 2020 16:59
@cpmeister cpmeister added this to the 2.5.6 milestone May 26, 2020
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@lolodomo @LoungeFlyZ
[dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
cacd647 
…nhab#7737)

Relative to openhab#7722

Let the socket closure close the in/out streams

Signed-off-by: Laurent Garnier <[email protected]>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@lolodomo @J-N-K
[dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
12b564c 
…nhab#7737)

Relative to openhab#7722

Let the socket closure close the in/out streams

Signed-off-by: Laurent Garnier <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@lolodomo @CSchlipp
[dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
b24f0d4 
…nhab#7737)

Relative to openhab#7722

Let the socket closure close the in/out streams

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
64d58fb 
…nhab#7737)

Relative to openhab#7722

Let the socket closure close the in/out streams

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
4f6ddba 
…nhab#7737)

Relative to openhab#7722

Let the socket closure close the in/out streams

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
182d559 
…nhab#7737)

Relative to openhab#7722

Let the socket closure close the in/out streams

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
d6fc965 
…nhab#7737)

Relative to openhab#7722

Let the socket closure close the in/out streams

Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@lolodomo @DaanMeijer
[dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
4dbfe42 
…nhab#7737)

Relative to openhab#7722

Let the socket closure close the in/out streams

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@lolodomo @markus7017
[dscalarm] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
3726324 
…nhab#7737)

Relative to openhab#7722

Let the socket closure close the in/out streams

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RSStephens RSStephens RSStephens approved these changes

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.
5 participants
@lolodomo @TravisBuddy @J-N-K @RSStephens @cpmeister