Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[freebox] Removed dependency on 'org.apache.commons.lang' #7727

Merged
merged 2 commits into from
May 23, 2020
Merged

[freebox] Removed dependency on 'org.apache.commons.lang' #7727

merged 2 commits into from
May 23, 2020

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier [email protected]

@lolodomo
Copy link
Contributor Author

lolodomo commented May 22, 2020 •
edited
Loading

This was pushed without a working maven buiuld (Maven build is currently not working due to download failures).

@lolodomo
Copy link
Contributor Author

Relative to #7722

@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@lolodomo
Use variables
95672b1 
Signed-off-by: Laurent Garnier <[email protected]>
martinvw
martinvw approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@martinvw martinvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the discussion about removing the dependency, but given we want it this looks good.

@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@lolodomo
Copy link
Contributor Author

This was pushed without a working maven buiuld (Maven build is currently not working due to download failures).

Using the offline mode (mvn -o clean install), the local build succeeded.

cpmeister
cpmeister approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 6f129fd into openhab:2.5.x May 23, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone May 23, 2020
@lolodomo lolodomo deleted the freebox_stringutils branch May 23, 2020 17:58
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@lolodomo @LoungeFlyZ
[freebox] Removed dependency on 'org.apache.commons.lang' (openhab#7727)
e3dbd25 
* [freebox] Removed dependency on 'org.apache.commons.lang'
* Use variables

Signed-off-by: Laurent Garnier <[email protected]>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@lolodomo @J-N-K
[freebox] Removed dependency on 'org.apache.commons.lang' (openhab#7727)
8ebbc6c 
* [freebox] Removed dependency on 'org.apache.commons.lang'
* Use variables

Signed-off-by: Laurent Garnier <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@lolodomo @CSchlipp
[freebox] Removed dependency on 'org.apache.commons.lang' (openhab#7727)
76fdb58 
* [freebox] Removed dependency on 'org.apache.commons.lang'
* Use variables

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[freebox] Removed dependency on 'org.apache.commons.lang' (openhab#7727)
fb602c5 
* [freebox] Removed dependency on 'org.apache.commons.lang'
* Use variables

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[freebox] Removed dependency on 'org.apache.commons.lang' (openhab#7727)
c7e97c7 
* [freebox] Removed dependency on 'org.apache.commons.lang'
* Use variables

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[freebox] Removed dependency on 'org.apache.commons.lang' (openhab#7727)
f2e8d5c 
* [freebox] Removed dependency on 'org.apache.commons.lang'
* Use variables

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[freebox] Removed dependency on 'org.apache.commons.lang' (openhab#7727)
a0bc715 
* [freebox] Removed dependency on 'org.apache.commons.lang'
* Use variables

Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@lolodomo @DaanMeijer
[freebox] Removed dependency on 'org.apache.commons.lang' (openhab#7727)
a29a1cc 
* [freebox] Removed dependency on 'org.apache.commons.lang'
* Use variables

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@lolodomo @markus7017
[freebox] Removed dependency on 'org.apache.commons.lang' (openhab#7727)
4cfb2c4 
* [freebox] Removed dependency on 'org.apache.commons.lang'
* Use variables

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K requested changes

@martinvw martinvw martinvw approved these changes

@cpmeister cpmeister cpmeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.
5 participants
@lolodomo @TravisBuddy @cpmeister @martinvw @J-N-K