[hueemulation] Fix broken fallback address #7305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]>
Hans-Reiner
pushed a commit
to Hans-Reiner/openhab2-addons
that referenced
this pull request
Apr 11, 2020
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Hans-Reiner Hoffmann <[email protected]>
yfre
pushed a commit
to yfre/openhab-addons
that referenced
this pull request
Apr 27, 2020
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Eugen Freiter <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
May 29, 2020
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]>
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]> Signed-off-by: CSchlipp <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
wborn
added a commit
to wborn/openhab-addons
that referenced
this pull request
Sep 10, 2020
Upgrades the Travis CI build environment to Ubuntu 18.04 (Bionic Beaver). The openjdk8 package is unsupported in newer Ubuntu versions. Also fixes the following Travis configuration validation warnings: * deprecated key sudo (The key `sudo` has no effect anymore.) * missing os, using the default linux Removes $HOME/.bnd/cache which does not exist after builds. It's also no longer necessary to disable IPv6 with builds. This was an actual issue in the hueemulation add-on which was fixed by openhab#7305. Signed-off-by: Wouter Born <[email protected]>
wborn
added a commit
to wborn/openhab-addons
that referenced
this pull request
Sep 10, 2020
Upgrades the Travis CI build environment to Ubuntu 20.04 (Focal Fossa). Also fixes the following Travis configuration validation warnings: * deprecated key sudo (The key `sudo` has no effect anymore.) * missing os, using the default linux Removes $HOME/.bnd/cache which does not exist after builds. It's also no longer necessary to disable IPv6 with builds. This was an actual issue in the hueemulation add-on which was fixed by openhab#7305. Signed-off-by: Wouter Born <[email protected]>
This was referenced Sep 10, 2020
Hilbrand
pushed a commit
that referenced
this pull request
Sep 10, 2020
Upgrades the Travis CI build environment to Ubuntu 20.04 (Focal Fossa). Also fixes the following Travis configuration validation warnings: * deprecated key sudo (The key `sudo` has no effect anymore.) * missing os, using the default linux Removes $HOME/.bnd/cache which does not exist after builds. It's also no longer necessary to disable IPv6 with builds. This was an actual issue in the hueemulation add-on which was fixed by #7305. Signed-off-by: Wouter Born <[email protected]>
Hilbrand
pushed a commit
that referenced
this pull request
Sep 10, 2020
Upgrades the Travis CI build environment to Ubuntu 18.04 (Bionic Beaver). The openjdk8 package is unsupported in newer Ubuntu versions. Also fixes the following Travis configuration validation warnings: * deprecated key sudo (The key `sudo` has no effect anymore.) * missing os, using the default linux Removes $HOME/.bnd/cache which does not exist after builds. It's also no longer necessary to disable IPv6 with builds. This was an actual issue in the hueemulation add-on which was fixed by #7305. Signed-off-by: Wouter Born <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Sep 12, 2020
…ab#8442) Upgrades the Travis CI build environment to Ubuntu 18.04 (Bionic Beaver). The openjdk8 package is unsupported in newer Ubuntu versions. Also fixes the following Travis configuration validation warnings: * deprecated key sudo (The key `sudo` has no effect anymore.) * missing os, using the default linux Removes $HOME/.bnd/cache which does not exist after builds. It's also no longer necessary to disable IPv6 with builds. This was an actual issue in the hueemulation add-on which was fixed by openhab#7305. Signed-off-by: Wouter Born <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
With the changes in openhab#6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
…ab#8442) Upgrades the Travis CI build environment to Ubuntu 18.04 (Bionic Beaver). The openjdk8 package is unsupported in newer Ubuntu versions. Also fixes the following Travis configuration validation warnings: * deprecated key sudo (The key `sudo` has no effect anymore.) * missing os, using the default linux Removes $HOME/.bnd/cache which does not exist after builds. It's also no longer necessary to disable IPv6 with builds. This was an actual issue in the hueemulation add-on which was fixed by openhab#7305. Signed-off-by: Wouter Born <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Oct 8, 2020
…ab#8442) Upgrades the Travis CI build environment to Ubuntu 18.04 (Bionic Beaver). The openjdk8 package is unsupported in newer Ubuntu versions. Also fixes the following Travis configuration validation warnings: * deprecated key sudo (The key `sudo` has no effect anymore.) * missing os, using the default linux Removes $HOME/.bnd/cache which does not exist after builds. It's also no longer necessary to disable IPv6 with builds. This was an actual issue in the hueemulation add-on which was fixed by openhab#7305. Signed-off-by: Wouter Born <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes in #6967 the
HueEmulationServiceOSGiTestalways fails for me.The reason is that if the
discoveryIpsare not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback.In my case the iterator on the
HashSetwould return an IPv6 address as first address.By using a
LinkedHashSetthe order is preserved and it will again use the primary IPv4 host address as fallback.