-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tado] Updated documentation for tado X #17932
Conversation
Signed-off-by: JPlenert <[email protected]>
@JPlenert looking at the API it seems we should be able to adapt the existing binding to support X devices as well. WDYT? |
I think that should be possible! If openhab had been written in C#, it would have been finished long ago - But I'm not a Java guy :-) |
Ok. I will have a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@JPlenert so it seems that the tado X products are based on Matter and that the tado Bridge X is a Matter "Thread Border Router" so I think that rather than trying to develop an integration of the Bridge X into the existing tado binding, we should rather plan to integrate the tado X HVAC control products via the OH Matter Binding which is planned to be released in OH v5.0 |
@andrewfg More then welcome! But the comment I made in the documentation stays true - this binding doesn't work with the tado X products and Matter Binding is not existing and tested with Tado X. |
Yes. The comment is fine. I already approved this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Signed-off-by: JPlenert [email protected]
As this is a small documentation improvement, i applied the small patch exception, but you might want to look into the signoff's as we have a real name policy.
For reference: https://www.openhab.org/docs/developer/contributing.html#sign-your-work
Updated the documentation of the tado binding, as the current binding is not compatible to the new tado X devices.
Inserted a swagger link to updated API for the new devices.