Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tado] Updated documentation for tado X #17932

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[tado] Updated documentation for tado X #17932

merged 1 commit into from
Dec 20, 2024

Conversation

JPlenert
Copy link
Contributor

Updated the documentation of the tado binding, as the current binding is not compatible to the new tado X devices.
Inserted a swagger link to updated API for the new devices.

@JPlenert JPlenert requested a review from andrewfg as a code owner December 20, 2024 09:57
@andrewfg
Copy link
Contributor

@JPlenert looking at the API it seems we should be able to adapt the existing binding to support X devices as well. WDYT?

@JPlenert
Copy link
Contributor Author

@JPlenert looking at the API it seems we should be able to adapt the existing binding to support X devices as well. WDYT?

I think that should be possible! If openhab had been written in C#, it would have been finished long ago - But I'm not a Java guy :-)

@andrewfg
Copy link
Contributor

I think that should be possible!

Ok. I will have a look at it.

Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewfg
Copy link
Contributor

@JPlenert so it seems that the tado X products are based on Matter and that the tado Bridge X is a Matter "Thread Border Router" so I think that rather than trying to develop an integration of the Bridge X into the existing tado binding, we should rather plan to integrate the tado X HVAC control products via the OH Matter Binding which is planned to be released in OH v5.0

@JPlenert
Copy link
Contributor Author

@andrewfg More then welcome! But the comment I made in the documentation stays true - this binding doesn't work with the tado X products and Matter Binding is not existing and tested with Tado X.

@andrewfg
Copy link
Contributor

Yes. The comment is fine. I already approved this PR.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Signed-off-by: JPlenert [email protected]

As this is a small documentation improvement, i applied the small patch exception, but you might want to look into the signoff's as we have a real name policy.
For reference: https://www.openhab.org/docs/developer/contributing.html#sign-your-work

@lsiepel lsiepel merged commit e91820c into openhab:main Dec 20, 2024
3 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Dec 20, 2024
@lsiepel lsiepel changed the title [tado.doc] Updated tado binding documentation for tado X [tado] Updated documentation for tado X Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants