Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velbus] New functionality & Bug fix #17926

Merged
merged 74 commits into from
Jan 4, 2025
Merged

[velbus] New functionality & Bug fix #17926

merged 74 commits into from
Jan 4, 2025

Conversation

Rosen01
Copy link
Contributor

@Rosen01 Rosen01 commented Dec 18, 2024

New functionality :

  • Add modules : VMB4LEDPWM-20, VMB8DC-20, VMBPIRO-10, VMBPIR-20, VMB8IN-20

Fix bug :

  • Correct typo in thing type for module VMB6PB-20.
  • Remove properties 'Refresh Interval' from modules VMBPIRC, VMBPIRM.
  • Add CH8 properties on VMB7IN module.
  • Channels name retrieved from modules not set correctly to the right channel.
  • Remove property 'Refresh Interval' from modules VMBPIRC, VMBPIRM.
  • Remove sub-address property for modules VMBPIRO.
  • VMBDALI, VMBDALI-20 use an exponential curve system for the dimming.
  • Update readme.

Link for testing : Releases

Signed-off-by: Daniel Rosengarten [email protected]

Rosen01 and others added 30 commits September 27, 2023 23:39
New functionnality :
- Add output channel for modules : VMBEL1, VMBEL2, VMBEL4, VMBELO, VMBELPIR. (#14179)
- Add module VMBDALI. (#14654)

Fix bug :
- No access to sub-address modules when adding manually the modules : VMBELO,VMBGPO, VMBGPOD, VMBGPOD-2 (#12702)
- Thermostat event wrongly fired when using push button on sub-address for modules VMBELO, VMBGPO, VMBGPOD, VMBGPOD_2.
- Wrong typeId for bridge alarms management.

Signed-off-by: Daniel Rosengarten <[email protected]>
Changed the management of VMBDALI white channel.

Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusBindingConstants.java

Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusBindingConstants.java

Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/discovery/VelbusThingDiscoveryService.java

Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusVirtualColorChannel.java

Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusVirtualColorChannel.java

Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusVirtualColorChannel.java

Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
* VelbusVirtualColorChannel class
Permits different values (CH0 or A0) to configure the virtual light's channels.
* VelbusColorChannel class
Makes color transformation easy with the rescale function.
* onPacketReceived interface
Stops processing packets when handler is disposed.

Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Thing upgrade instructions for VMBEL1, VMBEL2, VMBEL4, VMBELO.

Signed-off-by: Daniel Rosengarten <[email protected]>
Update Readme.

Signed-off-by: Daniel Rosengarten <[email protected]>
Add modules : VMB4RYLD-10, VMB4RYNO-10, VMB2BLE-10, VMB6PB-20, VMBEL1-20, VMBEL2-20, VMBEL4-20, VMBELO-20, VMBGP1-20, VMBGP2-20, VMBGP4-20, VMBGPO-20, VMBDALI-20, VMBEL4PIR-20, VMBGP4PIR-20

Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Added missing bundle reference in channel type.

Signed-off-by: Daniel Rosengarten <[email protected]>
Rosen01 and others added 18 commits July 25, 2024 17:20
Remove unneeded channels on modules VMB4PWMLED-20 and VMB8DC-20.

Signed-off-by: Daniel Rosengarten <[email protected]>
- Remove ClockAlarm channel group on modules VMB4LEDPWM-20 and VMB8DC-20
- Use exponential curve values for brightness on modules VMBDALI, VMBDALI-20, VMB4LEDPWM-20, VMB8DC-20

Signed-off-by: Daniel Rosengarten <[email protected]>
Fix bug :
- VMB8DC-20 uses a linear system for the dimming.
- VMB4LEDPWM-20, VMBDALI, VMBDALI-20 uses an exponential curve system for the dimming.

Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Update readme.

Signed-off-by: Daniel Rosengarten <[email protected]>
@Rosen01 Rosen01 requested a review from cedricboon as a code owner December 18, 2024 17:32
@lsiepel
Copy link
Contributor

lsiepel commented Dec 18, 2024

Thanks for this PR! Before i review i like to ask you if it would be possible to split this PR in 2 (or more) seperate PR's. One that fixes bugs and one that adds features (channels).
If not we have to deal with it ;-) but in general we prefer smaller PR's as they are easier to review, backport and show up independent in the release notes.

@Rosen01
Copy link
Contributor Author

Rosen01 commented Dec 23, 2024

Hi @lsiepel,

Sorry but I'm not familiar enough with GitHub to manage the split off the changes in different pull requests.
At the beginning, I just added new modules, but during the tests we found some old bugs in the code that I've directly corrected.

I know, it seems there are a lot of changes, but if you take a look :
I did some formatting of the code to be more "compliant" (changing the 1st letter from uppercase to lowercase of the functions).
I also split the .xml files from config, thing and update directories into smaller files and with more accurate names.

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Dec 23, 2024
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Dec 31, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.
Hope to get a confirmation from @cedricboon before i merge this.

For future PR's please split bug fixes from enhancements. This can be done in many ways, but for instance by creating an enhancement brancht on top of the bug fix branch. Or two completely independend branches. This would be easier to review, backport, list in release notes and fix regressions when needed. Thank you!

@lsiepel lsiepel merged commit e611b5d into openhab:main Jan 4, 2025
3 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Jan 4, 2025
GearrelW pushed a commit to GearrelW/openhab-addons that referenced this pull request Jan 12, 2025
* [velbus] New functionnality & Bug fix

Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]>
chilobo pushed a commit to chilobo/openhab-addons that referenced this pull request Feb 10, 2025
* [velbus] New functionnality & Bug fix

Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Christian Koch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants