-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[velbus] New functionality & Bug fix #17926
Conversation
New functionnality : - Add output channel for modules : VMBEL1, VMBEL2, VMBEL4, VMBELO, VMBELPIR. (#14179) - Add module VMBDALI. (#14654) Fix bug : - No access to sub-address modules when adding manually the modules : VMBELO,VMBGPO, VMBGPOD, VMBGPOD-2 (#12702) - Thermostat event wrongly fired when using push button on sub-address for modules VMBELO, VMBGPO, VMBGPOD, VMBGPOD_2. - Wrong typeId for bridge alarms management. Signed-off-by: Daniel Rosengarten <[email protected]>
Changed the management of VMBDALI white channel. Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusBindingConstants.java Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusBindingConstants.java Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/discovery/VelbusThingDiscoveryService.java Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusVirtualColorChannel.java Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusVirtualColorChannel.java Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusVirtualColorChannel.java Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
* VelbusVirtualColorChannel class Permits different values (CH0 or A0) to configure the virtual light's channels. * VelbusColorChannel class Makes color transformation easy with the rescale function. * onPacketReceived interface Stops processing packets when handler is disposed. Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Thing upgrade instructions for VMBEL1, VMBEL2, VMBEL4, VMBELO. Signed-off-by: Daniel Rosengarten <[email protected]>
Update Readme. Signed-off-by: Daniel Rosengarten <[email protected]>
Add modules : VMB4RYLD-10, VMB4RYNO-10, VMB2BLE-10, VMB6PB-20, VMBEL1-20, VMBEL2-20, VMBEL4-20, VMBELO-20, VMBGP1-20, VMBGP2-20, VMBGP4-20, VMBGPO-20, VMBDALI-20, VMBEL4PIR-20, VMBGP4PIR-20 Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Added missing bundle reference in channel type. Signed-off-by: Daniel Rosengarten <[email protected]>
Remove unneeded channels on modules VMB4PWMLED-20 and VMB8DC-20. Signed-off-by: Daniel Rosengarten <[email protected]>
- Remove ClockAlarm channel group on modules VMB4LEDPWM-20 and VMB8DC-20 - Use exponential curve values for brightness on modules VMBDALI, VMBDALI-20, VMB4LEDPWM-20, VMB8DC-20 Signed-off-by: Daniel Rosengarten <[email protected]>
Fix bug : - VMB8DC-20 uses a linear system for the dimming. - VMB4LEDPWM-20, VMBDALI, VMBDALI-20 uses an exponential curve system for the dimming. Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Update readme. Signed-off-by: Daniel Rosengarten <[email protected]>
Thanks for this PR! Before i review i like to ask you if it would be possible to split this PR in 2 (or more) seperate PR's. One that fixes bugs and one that adds features (channels). |
Hi @lsiepel, Sorry but I'm not familiar enough with GitHub to manage the split off the changes in different pull requests. I know, it seems there are a lot of changes, but if you take a look : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
Hope to get a confirmation from @cedricboon before i merge this.
For future PR's please split bug fixes from enhancements. This can be done in many ways, but for instance by creating an enhancement brancht on top of the bug fix branch. Or two completely independend branches. This would be easier to review, backport, list in release notes and fix regressions when needed. Thank you!
* [velbus] New functionnality & Bug fix Signed-off-by: Daniel Rosengarten <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]> Co-authored-by: Simonas Kazlauskas <[email protected]>
* [velbus] New functionnality & Bug fix Signed-off-by: Daniel Rosengarten <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]> Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Christian Koch <[email protected]>
New functionality :
Fix bug :
Link for testing : Releases
Signed-off-by: Daniel Rosengarten [email protected]